Clamp aligned_offset in MemorySnapshotSanitized [crashpad/crashpad : main]
3 views
Skip to first unread message
Mark Mentovai (Gerrit)
Jul 23, 2026, 5:50:22 PM (5 days ago) Jul 23
to Joshua Peraza, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Joshua Peraza
Mark Mentovai added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Mark Mentovai . resolved
Good to hear from you. Welcome back!
File snapshot/BUILD.gn
Line 335, Patchset 2 (Parent):
# There’s no way to make the link depend on this file. “inputs” doesn’t have
# the intended effect in a config. https://crbug.com/781858,
# https://crbug.com/796187.Mark Mentovai . unresolved
This was formatted correctly before!
(Oh, I know what this is, it’s the thing where `gn format` counts bytes instead of UTF-8 characters. Bad `gn format`!)
File snapshot/sanitized/memory_snapshot_sanitized.cc
Line 59, Patchset 2 (Latest):
((address_ + sizeof(Pointer) - 1) & ~(sizeof(Pointer) - 1)) - address_;Mark Mentovai . unresolved
`#include <algorithm>` and use `std::min(size, …)`, and then `aligned_offset` can even remain `const`.
Related details
Attention is currently required from:
- Joshua Peraza
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Jul 23, 2026, 6:14:41 PM (5 days ago) Jul 23
to Mark Mentovai, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Mark Mentovai
Joshua Peraza added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Mark Mentovai . resolved
Good to hear from you. Welcome back!
Joshua Peraza
Thanks!
File snapshot/BUILD.gn
Line 335, Patchset 2 (Parent):
# There’s no way to make the link depend on this file. “inputs” doesn’t have
# the intended effect in a config. https://crbug.com/781858,
# https://crbug.com/796187.Mark Mentovai . resolved
This was formatted correctly before!
(Oh, I know what this is, it’s the thing where `gn format` counts bytes instead of UTF-8 characters. Bad `gn format`!)
Joshua Peraza
Reformat reverted.
File snapshot/sanitized/memory_snapshot_sanitized.cc
Line 59, Patchset 2:
((address_ + sizeof(Pointer) - 1) & ~(sizeof(Pointer) - 1)) - address_;Mark Mentovai . resolved
`#include <algorithm>` and use `std::min(size, …)`, and then `aligned_offset` can even remain `const`.
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Jul 24, 2026, 9:50:35 AM (4 days ago) Jul 24
to Joshua Peraza, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Joshua Peraza
Mark Mentovai voted and added 2 comments![]( "Open in Gerrit")
Votes added by Mark Mentovai
| Code-Review | +1 |
2 comments
Patchset-level comments
Commit Message
Line 22, Patchset 3 (Latest):
Bug:500097298Mark Mentovai . unresolved
Missing a space after the colon.
Related details
Attention is currently required from:
- Joshua Peraza
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Jul 24, 2026, 12:30:38 PM (4 days ago) Jul 24
to Mark Mentovai, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Joshua Peraza voted and added 1 comment![]( "Open in Gerrit")
Votes added by Joshua Peraza
| Commit-Queue | +2 |
Missing a space after the colon.
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
crashpad-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 24, 2026, 12:46:45 PM (4 days ago) Jul 24
to Joshua Peraza, Mark Mentovai, crashp...@chromium.org
crashpa...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Clamp aligned_offset in MemorySnapshotSanitized
MemorySanitizer::Sanitize() computes the number of leading unaligned
bytes from the snapshot's base address and uses it as the length of a
memcpy into the data buffer and as the subtrahend for the word count.
When the snapshot is shorter than the alignment offset (an unaligned
base address with a sub-word region), the leading memcpy writes past the
end of the buffer and the word count underflows.
Clamp the offset to the buffer size so that short unaligned regions are
defaced in place.
Add MemorySnapshotSanitized.ShortUnalignedRegion64/32 unit tests
covering every (offset, size) pair below the pointer width.
Bug: 500097298
Change-Id: Ib58b96250631f760329f16d30a0e7b8b062394f2
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Joshua Peraza <jpe...@chromium.org>
Files:
- M snapshot/BUILD.gn
- M snapshot/sanitized/memory_snapshot_sanitized.cc
- A snapshot/sanitized/memory_snapshot_sanitized_test.cc
Change size: M
Delta: 3 files changed, 121 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages