Add CPEPrefix to third_party/zlib [crashpad/crashpad : main]

7 views
Skip to first unread message

Andrew Grieve (Gerrit)

unread,
Jun 1, 2026, 9:04:46 PM (4 days ago) Jun 1
to Andrew Grieve, Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai

Andrew Grieve voted and added 1 comment

Votes added by Andrew Grieve

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Andrew Grieve . resolved

Audited the list of Local Modifications, and this was the only one that's easy & makes sense to upstream (that hasn't already been upstreamed)

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I0927119bfa7a9c2528ccd4bbcaa255acc5d7fdbf
Gerrit-Change-Number: 7892565
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jun 2026 01:04:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Jun 2, 2026, 9:20:06 AM (4 days ago) Jun 2
to Andrew Grieve, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Andrew Grieve

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I0927119bfa7a9c2528ccd4bbcaa255acc5d7fdbf
Gerrit-Change-Number: 7892565
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jun 2026 13:20:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Jun 2, 2026, 9:40:36 AM (4 days ago) Jun 2
to Andrew Grieve, Mark Mentovai, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org

Andrew Grieve voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I0927119bfa7a9c2528ccd4bbcaa255acc5d7fdbf
Gerrit-Change-Number: 7892565
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jun 2026 13:40:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

crashpad-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Jun 2, 2026, 9:40:48 AM (4 days ago) Jun 2
to Andrew Grieve, Mark Mentovai, crashp...@chromium.org

crashpa...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Add CPEPrefix to third_party/zlib

Upstreaming https://chromium-review.googlesource.com/c/chromium/src/+/5096154
Change-Id: I0927119bfa7a9c2528ccd4bbcaa255acc5d7fdbf
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Andrew Grieve <agr...@chromium.org>
Files:
  • M third_party/zlib/README.crashpad
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I0927119bfa7a9c2528ccd4bbcaa255acc5d7fdbf
Gerrit-Change-Number: 7892565
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages