Fix Fuchsia roller [crashpad/crashpad : main]

1 view
Skip to first unread message

Joshua Peraza (Gerrit)

unread,
Feb 3, 2026, 12:14:37 PM (4 days ago) Feb 3
to Thomas Gales, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Thomas Gales

Joshua Peraza voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Gales
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If1eb1658ce238aae67a95ec15107c6ee5796a8c9
Gerrit-Change-Number: 7540418
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Gales <tga...@google.com>
Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
Gerrit-Reviewer: Thomas Gales <tga...@google.com>
Gerrit-Attention: Thomas Gales <tga...@google.com>
Gerrit-Comment-Date: Tue, 03 Feb 2026 17:14:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Feb 3, 2026, 12:22:37 PM (4 days ago) Feb 3
to Thomas Gales, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Thomas Gales

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Gales
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If1eb1658ce238aae67a95ec15107c6ee5796a8c9
Gerrit-Change-Number: 7540418
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Gales <tga...@google.com>
Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Thomas Gales <tga...@google.com>
Gerrit-Attention: Thomas Gales <tga...@google.com>
Gerrit-Comment-Date: Tue, 03 Feb 2026 17:22:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Thomas Gales (Gerrit)

unread,
Feb 3, 2026, 12:26:38 PM (4 days ago) Feb 3
to Mark Mentovai, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org

Thomas Gales voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If1eb1658ce238aae67a95ec15107c6ee5796a8c9
Gerrit-Change-Number: 7540418
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Gales <tga...@google.com>
Gerrit-Reviewer: Joshua Peraza <jpe...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Thomas Gales <tga...@google.com>
Gerrit-Comment-Date: Tue, 03 Feb 2026 17:26:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
Feb 3, 2026, 12:26:46 PM (4 days ago) Feb 3
to Thomas Gales, Mark Mentovai, Joshua Peraza, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:
Fix Fuchsia roller

The Fuchsia roller is failing due to a sign comparison issue in
httplib.h. Fuchsia no longer uses Crashpad for uploads, so we might as
well remove the dependency.
Fixed: 477270789
Test: `fx build`
Change-Id: If1eb1658ce238aae67a95ec15107c6ee5796a8c9
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Thomas Gales <tga...@google.com>
Reviewed-by: Joshua Peraza <jpe...@chromium.org>
Files:
  • M BUILD.gn
  • M util/BUILD.gn
Change size: XS
Delta: 2 files changed, 1 insertion(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai, +1 by Joshua Peraza
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If1eb1658ce238aae67a95ec15107c6ee5796a8c9
Gerrit-Change-Number: 7540418
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Gales <tga...@google.com>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages