Use EXCEPTION_STATE_IDENTITY_PROTECTED on iOS. [crashpad/crashpad : main]

9 views

Skip to first unread message

Justin Cohen (Gerrit)

unread,

Dec 2, 2025, 12:47:19 PMDec 2

to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Mark Mentovai

Justin Cohen added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Justin Cohen . resolved

This is need for using Blink on iOS. I'm not sure why PROTECTED is required by Apple for Blink on iOS, or even if the in-process design for iOS makes sense for Blink on iOS.

If it does, this appears to work, but my big open questions are:

(1) when to use EXCEPTION_STATE_IDENTITY_PROTECTED vs EXCEPTION_STATE_IDENTITY [perhaps as a flag passed to Crashpad, or maybe it's fine to use on anyone > iOS18]
(2) Why the PROTECTED API doesn't pass the task and thread like the non-PROTECTED version, and if it's OK to simply recover it to match the old API, like I do in this CL (util/mach/exc_server_variants.cc::469-513)
(3) Perhaps more minor, but the difference between ExcTraits and MachExcTraits each having their own kMachMessageIDExceptionRaiseStateIdentityProtected const (with the ExcTraits version unused)

Consider this is a first draft in what perhaps should be a conversation. Let me know if doing this over CL comments is OK, or if you'd prefer to chat.

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Mark Mentovai

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages