Add build/build_config.h in capture_memory.cc [crashpad/crashpad : main]

2 views
Skip to first unread message

Mark Mentovai (Gerrit)

unread,
May 10, 2024, 3:28:37 PMMay 10
to Arthur Wang, Thomas Gales, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Arthur Wang

Mark Mentovai added 1 comment

Commit Message
Line 9, Patchset 7 (Latest):Bug: crashpad:326459659,326458942,326459376,326459390,326459417,326458979,326459333,326459016,326458338,326458738,326459156,326459512,326458694
Mark Mentovai . unresolved

These bugs don’t have anything to do with this change.

Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Wang
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I486e7bcdb205de5b24846a8e782a6163c2ce8829
Gerrit-Change-Number: 5531439
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: Thomas Gales <tga...@google.com>
Gerrit-Attention: Arthur Wang <wuw...@chromium.org>
Gerrit-Comment-Date: Fri, 10 May 2024 19:28:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Arthur Wang (Gerrit)

unread,
May 10, 2024, 3:29:37 PMMay 10
to Mark Mentovai, Thomas Gales, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Mark Mentovai

Arthur Wang added 1 comment

Commit Message
Line 9, Patchset 7:Bug: crashpad:326459659,326458942,326459376,326459390,326459417,326458979,326459333,326459016,326458338,326458738,326459156,326459512,326458694
Mark Mentovai . resolved

These bugs don’t have anything to do with this change.

Arthur Wang

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I486e7bcdb205de5b24846a8e782a6163c2ce8829
Gerrit-Change-Number: 5531439
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: Thomas Gales <tga...@google.com>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Fri, 10 May 2024 19:29:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mark Mentovai <ma...@chromium.org>
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
May 10, 2024, 3:34:01 PMMay 10
to Arthur Wang, Thomas Gales, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Arthur Wang

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Wang
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I486e7bcdb205de5b24846a8e782a6163c2ce8829
Gerrit-Change-Number: 5531439
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: Thomas Gales <tga...@google.com>
Gerrit-Attention: Arthur Wang <wuw...@chromium.org>
Gerrit-Comment-Date: Fri, 10 May 2024 19:33:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Arthur Wang (Gerrit)

unread,
May 10, 2024, 3:34:17 PMMay 10
to Mark Mentovai, Thomas Gales, Crashpad LUCI CQ, crashp...@chromium.org

Arthur Wang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I486e7bcdb205de5b24846a8e782a6163c2ce8829
Gerrit-Change-Number: 5531439
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: Thomas Gales <tga...@google.com>
Gerrit-Comment-Date: Fri, 10 May 2024 19:34:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
May 10, 2024, 3:34:25 PMMay 10
to Arthur Wang, Mark Mentovai, Thomas Gales, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:
Add build/build_config.h in capture_memory.cc
Change-Id: I486e7bcdb205de5b24846a8e782a6163c2ce8829
Commit-Queue: Arthur Wang <wuw...@chromium.org>
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
  • M snapshot/capture_memory.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I486e7bcdb205de5b24846a8e782a6163c2ce8829
Gerrit-Change-Number: 5531439
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-CC: Thomas Gales <tga...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages