Silence unused-template warning [crashpad/crashpad : main]

[Victor Vianna (Gerrit)]

Attention needed from Mark Mentovai and Victor Vianna

Message from Victor Vianna

Set Ready For Review

CQ dry run passed! Sending for review (automated via send_after_cq_dryrun.py).

Open in Gerrit

Related details

Attention is currently required from:

• Mark Mentovai
• Victor Vianna

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: crashpad/crashpad

Gerrit-Branch: main

Gerrit-Change-Id: Id1657f3c7995866a112139ad28a2067b132b042d

Gerrit-Change-Number: 8236031

Gerrit-PatchSet: 3

Gerrit-Owner: Victor Vianna <victor...@google.com>

Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>

Gerrit-Reviewer: Victor Vianna <victor...@google.com>

Gerrit-CC: crashpa...@luci-project-accounts.iam.gserviceaccount.com <crashpa...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Mark Mentovai <ma...@chromium.org>

Gerrit-Attention: Victor Vianna <victor...@google.com>

Gerrit-Comment-Date: Tue, 11 Aug 2026 02:41:45 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Mark Mentovai (Gerrit)]

Attention needed from Victor Vianna

Mark Mentovai added 2 comments

File build/BUILDCONFIG.gn

Line 74, Patchset 3 (Latest): "//build:no_unused_template_warning",

Mark Mentovai . unresolved

It seems like the warnings are triggered by headers in the Fuchsia SDK. Is that fixable in the SDK? Is there a bug on file to track that? Ideally it would be referenced here, so that the -Wno could hopefully be removed someday.

File third_party/googletest/BUILD.gn

Line 49, Patchset 3 (Latest): configs = [ "//build:no_unused_template_warning" ]

Mark Mentovai . unresolved

Is this needed everywhere or can it be limited to just Fuchsia, as in the other file?

The linked bug has a try run that makes the need for Fuchsia clear. If this is needed too, you'd ideally be able to point to something that demands it. (A try run is OK.)

Open in Gerrit

Related details

Attention is currently required from:

• Victor Vianna

Submit Requirements:

• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: crashpad/crashpad

Gerrit-Branch: main

Gerrit-Change-Id: Id1657f3c7995866a112139ad28a2067b132b042d

Gerrit-Change-Number: 8236031

Gerrit-PatchSet: 3

Gerrit-Owner: Victor Vianna <victor...@google.com>

Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>

Gerrit-Reviewer: Victor Vianna <victor...@google.com>

Gerrit-CC: crashpa...@luci-project-accounts.iam.gserviceaccount.com <crashpa...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Victor Vianna <victor...@google.com>

Gerrit-Comment-Date: Tue, 11 Aug 2026 02:53:27 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No