Remove _atomic_thread_fence [chromium/mini_chromium : main]

0 views

Skip to first unread message

weijian pan (Gerrit)

unread,

May 15, 2024, 9:52:42 AMMay 15

to Mark Mentovai, crashp...@chromium.org

Attention needed from Mark Mentovai

weijian pan added 3 comments

Commit Message

Line 9, Patchset 5:

Fix compilation error with gcc Linux. std::memory_order is an enum class, not an enum, which removes implicit conversions in c++20.

Mark Mentovai . resolved

Wrap git commit messages at 72 columns.

weijian pan

Sure.

Line 11, Patchset 5:Bug: 338911999

Mark Mentovai . resolved

This is not a Chromium or Crashpad bug number.

weijian pan

Sry about this, I just raised a new issue.

File base/atomicops_internals_portable.h

Line 55, Patchset 5:

  // Work around libstdc++ bug 51038 where atomic_thread_fence was declared but
  // not defined, leading to the linker complaining about undefined references.

Mark Mentovai . resolved

If your libstdc++ is new enough to have C++20 support, is it also new enough for this bug to be fixed?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51038
It was fixed in 2011. Maybe we don’t need this branch at all any longer.

weijian pan

Yes, I noticed that minichromium and crashpad have recently enabled C++20. Compilers that support C++20 should be able to fix this bug. I think we should remove this branch.

Open in Gerrit

Related details

Attention is currently required from:

Mark Mentovai

Submit Requirements:

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages