ios: Use prebuilt mig on non-Mac hosts in util/BUILD.gn [crashpad/crashpad : main]
6 views
Skip to first unread message
Justin Cohen (Gerrit)
Oct 1, 2026, 4:47:54 PMOct 1
to Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai
Justin Cohen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Justin Cohen . resolved
Most of this CL is upstreaming crrev.com/c/2879859.
The new diff is:
```
@@ -58,12 +58,12 @@ if (crashpad_is_apple && !crashpad_is_tvos) {
args = [ "{{source}}" ]
if (crashpad_is_in_chromium) {
- if (!use_system_xcode) {
+ if (!use_system_xcode || host_os != "mac") {
import("//build/config/clang/clang.gni")
- import("//build/config/mac/mac_sdk.gni")
clang_path =
rebase_path("$clang_base_path/bin/", root_build_dir) + "clang"
if (host_os == "mac") {
+ import("//build/config/mac/mac_sdk.gni")
mig_path = "$mac_bin_path" + "mig"
migcom_path = "$mac_bin_path" + "../libexec/migcom"
} else if (host_os == "linux") {
```Related details
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Oct 1, 2026, 4:50:18 PMOct 1
to Justin Cohen, crashp...@chromium.org
Attention needed from Justin Cohen
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Oct 1, 2026, 4:50:39 PMOct 1
to Mark Mentovai, crashp...@chromium.org
Justin Cohen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Oct 1, 2026, 6:28:03 PMOct 1
to crashpa...@luci-project-accounts.iam.gserviceaccount.com, Mark Mentovai, crashp...@chromium.org
Justin Cohen submitted the change![]( "Open in Gerrit")
Change information
Commit message:
ios: Use prebuilt mig on non-Mac hosts in util/BUILD.gn
Upstream Linux prebuilt mig support from Chromium (crrev.com/c/2879859)
and enable it on non-Mac hosts even when `use_system_xcode` is true --
which is required for iOS builds. Also guard the `mac_sdk.gni` import
behind `host_os == "mac"`.
Bug: 568440770
Change-Id: I5420d6a6edd95f45c9e15d2a98279d714f89329d
Commit-Queue: Justin Cohen <justi...@google.com>
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
- M util/BUILD.gn
Change size: S
Delta: 1 file changed, 12 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai
Review-Enforcement: Code-Review+1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages