build: Propagate data_deps of crashpad_tests for Android build [crashpad/crashpad : main]
4 views
Skip to first unread message
Junji Watanabe (Gerrit)
May 21, 2025, 10:49:30 PM5/21/25
to Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen
Junji Watanabe voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
May 21, 2025, 10:57:09 PM5/21/25
to Junji Watanabe, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Junji Watanabe and Justin Cohen
Mark Mentovai added 1 comment![]( "Open in Gerrit")
File BUILD.gn
Line 41, Patchset 2 (Latest):
if (crashpad_is_android) {Mark Mentovai . unresolved
There is already a `crashpad_is_android` block on line 62 that you should use.
Related details
Attention is currently required from:
- Junji Watanabe
- Justin Cohen
Submit Requirements:
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Junji Watanabe (Gerrit)
May 21, 2025, 11:01:59 PM5/21/25
to Mark Mentovai, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen and Mark Mentovai
Junji Watanabe voted and added 1 comment![]( "Open in Gerrit")
Votes added by Junji Watanabe
| Code-Review | +1 |
There is already a `crashpad_is_android` block on line 62 that you should use.
Attention is currently required from:
- Justin Cohen
- Mark Mentovai
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
May 22, 2025, 6:53:59 AM5/22/25
to Junji Watanabe, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Junji Watanabe and Justin Cohen
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Junji Watanabe
- Justin Cohen
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Junji Watanabe (Gerrit)
May 22, 2025, 10:11:15 PM5/22/25
to Mark Mentovai, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen
Junji Watanabe voted![]( "Open in Gerrit")
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
May 22, 2025, 10:11:23 PM5/22/25
to Junji Watanabe, Mark Mentovai, Justin Cohen, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
build: Propagate data_deps of crashpad_tests for Android build
During Android build, `crashpad_tests__dist` target needs to copy
`crashpad_tests` and its data dependencies. Currently, the transitivie
data deps aren't propagated to as expected.
This CL and https://crrev.com/c/6567128 on Chromium test.gni will
fix this issue.
Bug: chromium:418874703
Change-Id: Idc9db4b0195f71db815df435c80c383c7a54476a
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Junji Watanabe <jw...@google.com>
Files:
- M BUILD.gn
Change size: S
Delta: 1 file changed, 14 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai, +0 by Junji Watanabe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages