build: Propagate data_deps of crashpad_tests for Android build [crashpad/crashpad : main]

4 views
Skip to first unread message

Junji Watanabe (Gerrit)

unread,
May 21, 2025, 10:49:30 PM5/21/25
to Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen

Junji Watanabe voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Justin Cohen
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Idc9db4b0195f71db815df435c80c383c7a54476a
Gerrit-Change-Number: 6577641
Gerrit-PatchSet: 2
Gerrit-Owner: Junji Watanabe <jw...@google.com>
Gerrit-Reviewer: Junji Watanabe <jw...@google.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Attention: Justin Cohen <justi...@chromium.org>
Gerrit-Comment-Date: Thu, 22 May 2025 02:49:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
May 21, 2025, 10:57:09 PM5/21/25
to Junji Watanabe, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Junji Watanabe and Justin Cohen

Mark Mentovai added 1 comment

File BUILD.gn
Line 41, Patchset 2 (Latest): if (crashpad_is_android) {
Mark Mentovai . unresolved

There is already a `crashpad_is_android` block on line 62 that you should use.

Open in Gerrit

Related details

Attention is currently required from:
  • Junji Watanabe
  • Justin Cohen
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Idc9db4b0195f71db815df435c80c383c7a54476a
    Gerrit-Change-Number: 6577641
    Gerrit-PatchSet: 2
    Gerrit-Owner: Junji Watanabe <jw...@google.com>
    Gerrit-Reviewer: Junji Watanabe <jw...@google.com>
    Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
    Gerrit-CC: Mark Mentovai <ma...@chromium.org>
    Gerrit-Attention: Junji Watanabe <jw...@google.com>
    Gerrit-Attention: Justin Cohen <justi...@chromium.org>
    Gerrit-Comment-Date: Thu, 22 May 2025 02:57:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Junji Watanabe (Gerrit)

    unread,
    May 21, 2025, 11:01:59 PM5/21/25
    to Mark Mentovai, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
    Attention needed from Justin Cohen and Mark Mentovai

    Junji Watanabe voted and added 1 comment

    Votes added by Junji Watanabe

    Code-Review+1

    1 comment

    File BUILD.gn
    Line 41, Patchset 2: if (crashpad_is_android) {
    Mark Mentovai . resolved

    There is already a `crashpad_is_android` block on line 62 that you should use.

    Junji Watanabe

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Justin Cohen
    • Mark Mentovai
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Idc9db4b0195f71db815df435c80c383c7a54476a
    Gerrit-Change-Number: 6577641
    Gerrit-PatchSet: 3
    Gerrit-Owner: Junji Watanabe <jw...@google.com>
    Gerrit-Reviewer: Junji Watanabe <jw...@google.com>
    Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
    Gerrit-CC: Mark Mentovai <ma...@chromium.org>
    Gerrit-Attention: Justin Cohen <justi...@chromium.org>
    Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
    Gerrit-Comment-Date: Thu, 22 May 2025 03:01:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Mark Mentovai <ma...@chromium.org>
    unsatisfied_requirement
    open
    diffy

    Mark Mentovai (Gerrit)

    unread,
    May 22, 2025, 6:53:59 AM5/22/25
    to Junji Watanabe, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
    Attention needed from Junji Watanabe and Justin Cohen

    Mark Mentovai voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Junji Watanabe
    • Justin Cohen
    Submit Requirements:
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Idc9db4b0195f71db815df435c80c383c7a54476a
    Gerrit-Change-Number: 6577641
    Gerrit-PatchSet: 3
    Gerrit-Owner: Junji Watanabe <jw...@google.com>
    Gerrit-Reviewer: Junji Watanabe <jw...@google.com>
    Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Attention: Junji Watanabe <jw...@google.com>
    Gerrit-Attention: Justin Cohen <justi...@chromium.org>
    Gerrit-Comment-Date: Thu, 22 May 2025 10:53:56 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Junji Watanabe (Gerrit)

    unread,
    May 22, 2025, 10:11:15 PM5/22/25
    to Mark Mentovai, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
    Attention needed from Justin Cohen

    Junji Watanabe voted

    Code-Review+0
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Justin Cohen
    Submit Requirements:
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Idc9db4b0195f71db815df435c80c383c7a54476a
    Gerrit-Change-Number: 6577641
    Gerrit-PatchSet: 3
    Gerrit-Owner: Junji Watanabe <jw...@google.com>
    Gerrit-Reviewer: Junji Watanabe <jw...@google.com>
    Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Attention: Justin Cohen <justi...@chromium.org>
    Gerrit-Comment-Date: Fri, 23 May 2025 02:11:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Crashpad LUCI CQ (Gerrit)

    unread,
    May 22, 2025, 10:11:23 PM5/22/25
    to Junji Watanabe, Mark Mentovai, Justin Cohen, crashp...@chromium.org

    Crashpad LUCI CQ submitted the change

    Change information

    Commit message:
    build: Propagate data_deps of crashpad_tests for Android build

    During Android build, `crashpad_tests__dist` target needs to copy
    `crashpad_tests` and its data dependencies. Currently, the transitivie
    data deps aren't propagated to as expected.
    This CL and https://crrev.com/c/6567128 on Chromium test.gni will
    fix this issue.
    Bug: chromium:418874703
    Change-Id: Idc9db4b0195f71db815df435c80c383c7a54476a
    Reviewed-by: Mark Mentovai <ma...@chromium.org>
    Commit-Queue: Junji Watanabe <jw...@google.com>
    Files:
    • M BUILD.gn
    Change size: S
    Delta: 1 file changed, 14 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mark Mentovai, +0 by Junji Watanabe
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Idc9db4b0195f71db815df435c80c383c7a54476a
    Gerrit-Change-Number: 6577641
    Gerrit-PatchSet: 4
    Gerrit-Owner: Junji Watanabe <jw...@google.com>
    Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages