Busybody: `gn format` pass [crashpad/crashpad : main]

20 views
Skip to first unread message

Will Harris (Gerrit)

unread,
Apr 28, 2026, 2:18:30 AM (7 days ago) Apr 28
to Kalvin Lee, Will Harris, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Kalvin Lee

Will Harris voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kalvin Lee
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I3da0041fcc1763ca1cf25609cb30e951ea61ceb9
Gerrit-Change-Number: 7792265
Gerrit-PatchSet: 1
Gerrit-Owner: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Will Harris <w...@chromium.org>
Gerrit-Attention: Kalvin Lee <kd...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 06:18:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

crashpad-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Apr 28, 2026, 2:26:57 AM (7 days ago) Apr 28
to Kalvin Lee, Will Harris, crashp...@chromium.org

crashpa...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
Busybody: `gn format` pass
Change-Id: I3da0041fcc1763ca1cf25609cb30e951ea61ceb9
Reviewed-by: Will Harris <w...@chromium.org>
Commit-Queue: Kalvin Lee <kd...@chromium.org>
Files:
  • M handler/BUILD.gn
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Will Harris
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I3da0041fcc1763ca1cf25609cb30e951ea61ceb9
Gerrit-Change-Number: 7792265
Gerrit-PatchSet: 2
Gerrit-Owner: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Will Harris <w...@chromium.org>
open
diffy
satisfied_requirement

Kalvin Lee (Gerrit)

unread,
Apr 28, 2026, 12:28:49 PM (7 days ago) Apr 28
to Will Harris, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org

Kalvin Lee voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I3da0041fcc1763ca1cf25609cb30e951ea61ceb9
Gerrit-Change-Number: 7792265
Gerrit-PatchSet: 1
Gerrit-Owner: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Will Harris <w...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 06:26:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Kalvin Lee (Gerrit)

unread,
Apr 28, 2026, 12:28:49 PM (7 days ago) Apr 28
to Will Harris, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Will Harris

Kalvin Lee added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kalvin Lee . resolved

(Drop reviewers who declare themselves inactive) Roll d3 on Gerrit-suggested list of reviewers -> 1 -> Will to review, please.

Open in Gerrit

Related details

Attention is currently required from:
  • Will Harris
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I3da0041fcc1763ca1cf25609cb30e951ea61ceb9
Gerrit-Change-Number: 7792265
Gerrit-PatchSet: 1
Gerrit-Owner: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Will Harris <w...@chromium.org>
Gerrit-Attention: Will Harris <w...@chromium.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 06:16:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages