Build mini_chromium with C++23 [chromium/mini_chromium : main]
0 views
Skip to first unread message
Joshua Peraza (Gerrit)
Dec 17, 2025, 5:35:54 PM (2 days ago) Dec 17
to Victor Vianna, crashp...@chromium.org
Attention needed from Victor Vianna
Joshua Peraza voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Victor Vianna
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Vianna (Gerrit)
Dec 17, 2025, 5:36:08 PM (2 days ago) Dec 17
to Joshua Peraza, crashp...@chromium.org
Victor Vianna submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Build mini_chromium with C++23
For consistency with crrev.com/c/7170560. //base will soon use
C++23 features, so this change is required for mini_chromium to keep
building.
Bug: 388070065
Change-Id: I3b7c360a1e9c17e1ab534cc8b7723c82ccf593e9
Reviewed-by: Joshua Peraza <jpe...@chromium.org>
Files:
- M build/config/BUILD.gn
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joshua Peraza
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Dec 18, 2025, 8:07:59 AM (20 hours ago) Dec 18
to Joshua Peraza, crashp...@chromium.org
Mark Mentovai added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Mark Mentovai . resolved
This change is fine, but keep in mind that minu_chromium will not automatically require C++23 just because Chromium base does. mini_chromium is permitted (and often encouraged) to use different implementations than Chromium base. It's not a direct copy of base.
What is important is that mini_chromium remain interface-compatible with the Chromium base interfaces that it implements. So this change to use C++23 for mini_chromium and thus Crashpad is mostly important if any of those interfaces will be changing in a way that depends on C++23. I don't know what the C++23 migration plans are, but it's possible that there won't be any such changes, at least not for a while.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages