[fuchsia] Propagate module initialization failure [crashpad/crashpad : main]

[Alex Pankhurst (Gerrit)]

Attention needed from Thomas Gales

Alex Pankhurst added 1 comment

File snapshot/fuchsia/process_reader_fuchsia.h

Line 114, Patchset 4 (Latest): std::optional<
std::reference_wrapper<const std::vector<ProcessReaderFuchsia::Module>>>

Alex Pankhurst . unresolved

I think having to use `std::reference_wrapper` here is too cumbersome. Can we either:

• have a separate method that returns whether the modules were successfully initialized

• store a `std::optional<std::vector<..>>` and return a `const std::optional<std::vector<...>> &`

• use the fact an empty module list is unexpected and check for the vector being empty?

Open in Gerrit

Related details

Attention is currently required from:

• Thomas Gales

Submit Requirements:

• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: crashpad/crashpad

Gerrit-Branch: main

Gerrit-Change-Id: I569ac405bd3632ad821d50382369cb31e1f75536

Gerrit-Change-Number: 6576640

Gerrit-PatchSet: 4

Gerrit-Owner: Thomas Gales <tga...@google.com>

Gerrit-Reviewer: Alex Pankhurst <pank...@google.com>

Gerrit-Attention: Thomas Gales <tga...@google.com>

Gerrit-Comment-Date: Wed, 21 May 2025 18:52:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No