Add dump_minidump_annotations [crashpad/crashpad : main]

Brian Sheedy (Gerrit)

unread,

Feb 23, 2023, 5:26:45 PM2/23/23

to Joshua Peraza, crashp...@chromium.org

Attention is currently required from: Joshua Peraza.

View Change

1 comment:

Patchset:

Patch Set #2:

PTAL

Sample output from a Chromium GPU process minidump:

```
Module: /usr/local/google/code/clankium/src/out/gpu/chrome
  Simple Annotations
  Vectored Annotations
  Annotation Objects
    annotation_objects["gpu-url-chunk"] = http://127.0.0.1:32879/content/test/data/gpu/pixel_video_context_loss.html?src=/media/test/data/four-colors.mp4
    annotation_objects["gpu-gl-context-is-virtual"] = 0
    annotation_objects["gr-context-type"] = 1
    annotation_objects["variations"] = 2510663e-73703436,b13ca3d9-84f6cff8,13e2821-c0236c9e,13427e22-3f4a17df,87f33ad6-3f4a17df,250dda8b-3f4a17df,9f476f76-3f4a17df,65570806-377be55a,92d2eb18-fa10226e,1584cf60-3f4a17df,4852ec7f-3f4a17df,5f2c0f7c-3f4a17df,3fd33f16-27b09c4c,36d5ee52-3f4a17df,391562d6-3f4a17df,8bccc03b-3f4a17df,7e398fb8-3f4a17df,5349039a-3f4a17df,3095b8fe-3f4a17df,5de2eeca-3f4a17df,da493d3c-3f4a17df,e28cd73c-3f4a17df,f3ed486d-3f4a17df,5c783e42-8f8fa88f,4ff8f5b5-caf7a452,5f36436a-f799c15e,baee3c29-3f4a17df,9fe21c85-3f4a17df,ade3efeb-e1cc0f14,db59f83a-3f4a17df,1166396-1166396,bbaef9b4-3f4a17df,55ba4cfa-3f4a17df,fc7e4d22-3f4a17df,8963b549-3f4a17df,c297985a-3f4a17df,
    annotation_objects["num-experiments"] = 36
    annotation_objects["vulkan-api-version"] = 1.3.240
    annotation_objects["egl-display-type"] = angle:Vulkan
    annotation_objects["gpu-gl-renderer"] = ANGLE (NVIDIA, Vulkan 1.3.194 (NVIDIA Quadro P1000 (0x00001CB1)), NVIDIA-510.85.2.0)
    annotation_objects["gpu-gl-vendor"] = Google Inc. (NVIDIA)
    annotation_objects["gpu-generation-intel"] = 0
    annotation_objects["gpu-vsver"] = 1.00
    annotation_objects["gpu-psver"] = 1.00
    annotation_objects["gpu-driver"] = 510.85.02
    annotation_objects["gpu_count"] = 1
    annotation_objects["gpu-devid"] = 0x1cb1
    annotation_objects["gpu-venid"] = 0x10de
    annotation_objects["switch-9"] = --field-trial-handle=0,i,5890857200490588528,8178675155134540264
    annotation_objects["switch-8"] = --shared-files
    annotation_objects["switch-7"] = --use-gl=angle
    annotation_objects["osarch"] = x86_64
    annotation_objects["pid"] = 771521
    annotation_objects["ptype"] = gpu-process
    annotation_objects["switch-6"] = --change-stack-guard-on-fork=enable
    annotation_objects["switch-5"] = --user-data-dir=/tmp/tmpr1y2qx1t
    annotation_objects["switch-4"] = --noerrdialogs
    annotation_objects["switch-3"] = --enable-crash-reporter=,
    annotation_objects["switch-2"] = --crashpad-handler-pid=771487
    annotation_objects["switch-1"] = --use-cmd-decoder=passthrough
    annotation_objects["num-switches"] = 13
Module: linux-vdso.so.1
  Simple Annotations
  Vectored Annotations
  Annotation Objects
Module: libdl.so.2
  Simple Annotations
  Vectored Annotations
  Annotation Objects
...
```

I somewhat modeled the output format after `minidump_dump`'s, although I have no strong preferences about that.

To view, visit change 4287994. To unsubscribe, or for help writing mail filters, visit settings.

Joshua Peraza (Gerrit)

unread,

Feb 23, 2023, 6:24:47 PM2/23/23

to Brian Sheedy, crashp...@chromium.org

Attention is currently required from: Brian Sheedy.

View Change

6 comments:

File tools/dump_minidump_annotations.cc:
- Patch Set #2, Line 19:
```
#include "util/stream/log_output_stream.h"
```
  not needed
- Patch Set #2, Line 30: PID
  PATH
- Patch Set #2, Line 31: Operate on Crashpad crash report databases.
  Dump Annotations from minidumps.
- Patch Set #2, Line 44: MinidumpDumpMain
  DumpMinidumpAnnotationsMain
- Patch Set #2, Line 51: kOptionDatabase
  delete
- Patch Set #2, Line 72: "d:"
  ""

To view, visit change 4287994. To unsubscribe, or for help writing mail filters, visit settings.

Brian Sheedy (Gerrit)

unread,

Feb 23, 2023, 6:29:56 PM2/23/23

to Joshua Peraza, crashp...@chromium.org

Attention is currently required from: Joshua Peraza.

View Change

6 comments:

File tools/dump_minidump_annotations.cc:

Patch Set #2, Line 19:


#include "util/stream/log_output_stream.h"

not needed

- Done

- Patch Set #2, Line 30: PID
  PATH

- Done

- Patch Set #2, Line 31: Operate on Crashpad crash report databases.
  Dump Annotations from minidumps.

- Done

- Patch Set #2, Line 44: MinidumpDumpMain
  DumpMinidumpAnnotationsMain

- Done

- Patch Set #2, Line 51: kOptionDatabase
  delete

- Done

- Patch Set #2, Line 72: "d:"
  ""

- Done

To view, visit change 4287994. To unsubscribe, or for help writing mail filters, visit settings.

Joshua Peraza (Gerrit)

unread,

Feb 23, 2023, 6:31:52 PM2/23/23

to Brian Sheedy, crashp...@chromium.org

Attention is currently required from: Brian Sheedy.

Patch set 3:Code-Review +1

View Change

To view, visit change 4287994. To unsubscribe, or for help writing mail filters, visit settings.

Brian Sheedy (Gerrit)

unread,

Feb 23, 2023, 6:32:15 PM2/23/23

to Joshua Peraza, crashp...@chromium.org

Patch set 3:Commit-Queue +2

View Change

To view, visit change 4287994. To unsubscribe, or for help writing mail filters, visit settings.

Brian Sheedy (Gerrit)

unread,

Feb 24, 2023, 5:38:16 PM2/24/23

to Crashpad LUCI CQ, Joshua Peraza, crashp...@chromium.org

Attention is currently required from: Brian Sheedy.

Patch set 8:Commit-Queue +2

View Change

To view, visit change 4287994. To unsubscribe, or for help writing mail filters, visit settings.

Crashpad LUCI CQ (Gerrit)

unread,

Feb 24, 2023, 5:38:28 PM2/24/23

to Brian Sheedy, Joshua Peraza, crashp...@chromium.org

Crashpad LUCI CQ submitted this change.

View Change



3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: tools/BUILD.gn
Insertions: 5, Deletions: 0.

@@ -34,6 +34,11 @@
     "../snapshot",
     "../util",
   ]
+
+  if (crashpad_is_win) {
+    cflags =
+        [ "/wd4201" ]  # nonstandard extension used : nameless struct/union
+  }
 }
 
 if (!crashpad_is_ios) {
```
```
The name of the file: tools/dump_minidump_annotations.cc
Insertions: 3, Deletions: 1.

@@ -94,7 +94,9 @@
   }
 
   FileReader reader;
-  if (!reader.Open(base::FilePath(options.minidump))) {
+  if (!reader.Open(base::FilePath(
+      ToolSupport::CommandLineArgumentToFilePathStringType(
+          options.minidump)))) {
     return EXIT_FAILURE;
   }
 
```

Approvals:
  Brian Sheedy: Commit
  Joshua Peraza: Looks good to me

Add dump_minidump_annotations

Adds the dump_minidump_annotations tool (modified from jperaza's WIP
code). This works similarly to Breakpad's minidump_dump tool, but:

1. Is available on Windows
2. Only dumps simple/vectored annotations and annotation objects instead
   of the entire minidump contents.

Current use case for this is to be able to get a minidump's process
type on Windows without having to go through symbolization, but there
may be other use cases in the future.

Bug: chromium:1006331
Change-Id: I392024e230c10ea18673b3cf0d0ad4793d21f5eb
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4287994
Reviewed-by: Joshua Peraza <jpe...@chromium.org>
Commit-Queue: Brian Sheedy <bsh...@chromium.org>
---
M tools/BUILD.gn
A tools/dump_minidump_annotations.cc
2 files changed, 187 insertions(+), 0 deletions(-)

To view, visit change 4287994. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward