IWYU: Include base/logging.h in crash_handler_tvos.cc [crashpad/crashpad : main]

1 view

Skip to first unread message

Raphael Kubo da Costa (Gerrit)

unread,

May 15, 2025, 10:56:44 AM5/15/25

to Mark Mentovai, Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Mark Mentovai

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Mark Mentovai

Submit Requirements:

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Mark Mentovai (Gerrit)

unread,

May 15, 2025, 1:06:58 PM5/15/25

to Raphael Kubo da Costa, Justin Cohen, Gyuyoung Kim, Julie Jeongeun Kim, Abhijeet Kandalkar, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Raphael Kubo da Costa

Mark Mentovai added 1 comment

File client/crash_handler_tvos.cc

Line 61, Patchset 1 (Latest): LOG(ERROR) << "Unable to install crash handlers";

Mark Mentovai . unresolved

You can just get rid of this. InstallCrashHandlers promises to log the problem, and with more detail, too: it’ll tell you why `sigaction` failed, and for which signal.

Open in Gerrit

Related details

Attention is currently required from:

Raphael Kubo da Costa

Submit Requirements:

Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages