[DEPS] Rely on buildtools recursedep to fetch clang-format [crashpad/crashpad : main]
0 views
Skip to first unread message
Josip Sokcevic (Gerrit)
May 30, 2024, 6:34:34 PMMay 30
to Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai
Josip Sokcevic added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Josip Sokcevic . resolved
Tested locally by modifying one of the c files, removed ./crashpad/buildtools/linux64/format/clang-format, re-ran gclient sync and executed git cl format.
Related details
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
May 31, 2024, 10:21:58 AMMay 31
to Josip Sokcevic, crashp...@chromium.org
Attention needed from Josip Sokcevic
Mark Mentovai voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Mentovai
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Josip Sokcevic
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Josip Sokcevic (Gerrit)
May 31, 2024, 10:28:24 AMMay 31
to Mark Mentovai, crashp...@chromium.org
Josip Sokcevic voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Josip Sokcevic (Gerrit)
Jun 4, 2024, 12:20:00 PMJun 4
to Code Review Nudger, Crashpad LUCI CQ, Mark Mentovai, crashp...@chromium.org
Josip Sokcevic added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Josip Sokcevic . resolved
This is failing due to updated version of buildtools. Filed http://b/344879760 to get that fixed.
Related details
Attention set is empty
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages