Silence unused-template warning on fuchsia [crashpad/crashpad : main]

0 views

Skip to first unread message

Victor Vianna (Gerrit)

unread,

Aug 17, 2026, 9:10:06 PM (15 hours ago) Aug 17

to Mark Mentovai, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org

Attention needed from Mark Mentovai

Victor Vianna added 2 comments

File build/BUILDCONFIG.gn

Line 74, Patchset 3: "//build:no_unused_template_warning",

Mark Mentovai . resolved

It seems like the warnings are triggered by headers in the Fuchsia SDK. Is that fixable in the SDK? Is there a bug on file to track that? Ideally it would be referenced here, so that the -Wno could hopefully be removed someday.

Victor Vianna

I landed a patch in the SDK but apparently it wasn't enough. I'll send a new one.

File third_party/googletest/BUILD.gn

Line 49, Patchset 3: configs = [ "//build:no_unused_template_warning" ]

Mark Mentovai . resolved

Is this needed everywhere or can it be limited to just Fuchsia, as in the other file?
The linked bug has a try run that makes the need for Fuchsia clear. If this is needed too, you'd ideally be able to point to something that demands it. (A try run is OK.)

Victor Vianna

I linked to a trybot failure now.

Open in Gerrit

Related details

Attention is currently required from:

Mark Mentovai

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages