[luci-milo.cfg] Add luci only consoles [crashpad/crashpad : infra/config]

9 views
Skip to first unread message

Ryan Tseng (Gerrit)

unread,
Jul 24, 2018, 6:00:16 PM7/24/18
to Jao-ke Chin-Lee, Dirk Pranke, Commit Bot, crashp...@chromium.org

ptal

View Change

    To view, visit change 1149009. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: infra/config
    Gerrit-Change-Id: I6d8cad25b6d1e8b671e84066efdc7d1eb2bdb508
    Gerrit-Change-Number: 1149009
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ryan Tseng <hin...@chromium.org>
    Gerrit-Reviewer: Dirk Pranke <dpr...@chromium.org>
    Gerrit-Reviewer: Jao-ke Chin-Lee <jchi...@chromium.org>
    Gerrit-Reviewer: Ryan Tseng <hin...@chromium.org>
    Gerrit-CC: Commit Bot <commi...@chromium.org>
    Gerrit-Comment-Date: Tue, 24 Jul 2018 22:00:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Dirk Pranke (Gerrit)

    unread,
    Jul 24, 2018, 6:03:32 PM7/24/18
    to Ryan Tseng, Jao-ke Chin-Lee, Commit Bot, crashp...@chromium.org

    rs- lgtm.

    Patch set 2:Code-Review +1

    View Change

      To view, visit change 1149009. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: crashpad/crashpad
      Gerrit-Branch: infra/config
      Gerrit-Change-Id: I6d8cad25b6d1e8b671e84066efdc7d1eb2bdb508
      Gerrit-Change-Number: 1149009
      Gerrit-PatchSet: 2
      Gerrit-Owner: Ryan Tseng <hin...@chromium.org>
      Gerrit-Reviewer: Dirk Pranke <dpr...@chromium.org>
      Gerrit-Reviewer: Jao-ke Chin-Lee <jchi...@chromium.org>
      Gerrit-Reviewer: Ryan Tseng <hin...@chromium.org>
      Gerrit-CC: Commit Bot <commi...@chromium.org>
      Gerrit-Comment-Date: Tue, 24 Jul 2018 22:03:31 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      Ryan Tseng (Gerrit)

      unread,
      Jul 24, 2018, 6:04:42 PM7/24/18
      to Dirk Pranke, Jao-ke Chin-Lee, Commit Bot, crashp...@chromium.org

      Patch set 2:Commit-Queue +2

      View Change

        To view, visit change 1149009. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: crashpad/crashpad
        Gerrit-Branch: infra/config
        Gerrit-Change-Id: I6d8cad25b6d1e8b671e84066efdc7d1eb2bdb508
        Gerrit-Change-Number: 1149009
        Gerrit-PatchSet: 2
        Gerrit-Owner: Ryan Tseng <hin...@chromium.org>
        Gerrit-Reviewer: Dirk Pranke <dpr...@chromium.org>
        Gerrit-Reviewer: Jao-ke Chin-Lee <jchi...@chromium.org>
        Gerrit-Reviewer: Ryan Tseng <hin...@chromium.org>
        Gerrit-CC: Commit Bot <commi...@chromium.org>
        Gerrit-Comment-Date: Tue, 24 Jul 2018 22:04:40 +0000

        Commit Bot (Gerrit)

        unread,
        Jul 24, 2018, 6:05:32 PM7/24/18
        to Ryan Tseng, Dirk Pranke, Jao-ke Chin-Lee, crashp...@chromium.org

        Commit Bot merged this change.

        View Change

        Approvals: Dirk Pranke: Looks good to me Ryan Tseng: Commit
        [luci-milo.cfg] Add luci only consoles

        Useful for migration


        Bug: 865729
        Change-Id: I6d8cad25b6d1e8b671e84066efdc7d1eb2bdb508
        Reviewed-on: https://chromium-review.googlesource.com/1149009
        Reviewed-by: Dirk Pranke <dpr...@chromium.org>
        Commit-Queue: Ryan Tseng <hin...@chromium.org>
        ---
        M luci-milo.cfg
        1 file changed, 102 insertions(+), 0 deletions(-)


        To view, visit change 1149009. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: crashpad/crashpad
        Gerrit-Branch: infra/config
        Gerrit-Change-Id: I6d8cad25b6d1e8b671e84066efdc7d1eb2bdb508
        Gerrit-Change-Number: 1149009
        Gerrit-PatchSet: 3
        Gerrit-Owner: Ryan Tseng <hin...@chromium.org>
        Gerrit-Reviewer: Commit Bot <commi...@chromium.org>
        Gerrit-Reviewer: Dirk Pranke <dpr...@chromium.org>
        Gerrit-Reviewer: Jao-ke Chin-Lee <jchi...@chromium.org>
        Gerrit-Reviewer: Ryan Tseng <hin...@chromium.org>
        Gerrit-MessageType: merged

        ฐณัชศ์กร เอี่ยมสอาด (Gerrit)

        unread,
        May 21, 2024, 11:53:25 PMMay 21
        to Ryan Tseng, Dirk Pranke, Jao-ke Chin-Lee, crashp...@chromium.org

        ฐณัชศ์กร เอี่ยมสอาด voted Commit-Queue+1

        Commit-Queue+1
        Open in Gerrit

        Related details

        Attention set is empty
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: crashpad/crashpad
        Gerrit-Branch: infra/config
        Gerrit-Change-Id: I6d8cad25b6d1e8b671e84066efdc7d1eb2bdb508
        Gerrit-Change-Number: 1149009
        Gerrit-PatchSet: 3
        Gerrit-Owner: Ryan Tseng <hin...@chromium.org>
        Gerrit-Reviewer: Commit Bot <commi...@chromium.org>
        Gerrit-Reviewer: Dirk Pranke <dpr...@google.com>
        Gerrit-Reviewer: Jao-ke Chin-Lee <jchi...@chromium.org>
        Gerrit-Reviewer: Ryan Tseng <hin...@chromium.org>
        Gerrit-Reviewer: ฐณัชศ์กร เอี่ยมสอาด <manzasi...@gmail.com>
        Gerrit-Comment-Date: Wed, 22 May 2024 03:12:47 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages