Will Harris (Gerrit)

unread,

Nov 13, 2025, 12:21:09 PMNov 13

to Bo Wang, Crashpad LUCI CQ, Peng Zhou, Joshua Peraza, Mark Mentovai, Will Harris, crashp...@chromium.org

Attention needed from Bo Wang, Joshua Peraza and Mark Mentovai

Will Harris added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Will Harris . unresolved

Hi thanks for your CL - is there a bug/issue for this, what defect/issue is this trying to solve?

Open in Gerrit

Related details

Attention is currently required from:

Bo Wang
Joshua Peraza
Mark Mentovai

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Mark Mentovai (Gerrit)

unread,

Nov 13, 2025, 2:35:37 PMNov 13

to Bo Wang, Crashpad LUCI CQ, Peng Zhou, Joshua Peraza, Will Harris, crashp...@chromium.org

Attention needed from Bo Wang and Joshua Peraza

Mark Mentovai added 2 comments

File CONTRIBUTORS

Line 12, Patchset 2 (Latest):Bo Wang <wang...@bytedance.com>

Mark Mentovai . unresolved

Thanks for your patch!

This contribution isn’t significant enough to support inclusion in this file.

File tools/dump_minidump_annotations.cc

File-level comment, Patchset 2 (Latest):

Mark Mentovai . resolved

I’m honestly surprised that we have this tool at all. This really is minidump_dump’s territory.

Open in Gerrit

Related details

Attention is currently required from:

Bo Wang
Joshua Peraza

Submit Requirements:

Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Bo Wang (Gerrit)

unread,

Nov 14, 2025, 8:27:26 AMNov 14

to Crashpad LUCI CQ, Peng Zhou, Joshua Peraza, Mark Mentovai, Will Harris, crashp...@chromium.org

Attention needed from Joshua Peraza, Mark Mentovai and Will Harris

Bo Wang added 2 comments

Patchset-level comments

File-level comment, Patchset 2:

Will Harris . resolved

Hi thanks for your CL - is there a bug/issue for this, what defect/issue is this trying to solve?

Bo Wang

Hi, thanks for the review.

In our use case, our application integrates Crashpad and we analyze captured crashes using dump_minidump_annotations on the backend. We also rely on snapshot-level simple annotations, but noticed that the tool currently doesn’t output the AnnotationsSimpleMap from the process snapshot.

This CL adds that missing functionality so that snapshot-level simple annotations can be inspected alongside module-level annotations.

This issue was discovered during our internal crash analysis workflow and is not currently tracked by a public bug/issue. If needed, I can file one — just let me know.

File CONTRIBUTORS

Line 12, Patchset 2:Bo Wang <wang...@bytedance.com>

Mark Mentovai . resolved

Thanks for your patch!
This contribution isn’t significant enough to support inclusion in this file.

Bo Wang

Thanks for the response. Understood — I’ve already removed my entry from that file.

Open in Gerrit

Related details

Attention is currently required from:

Joshua Peraza
Mark Mentovai
Will Harris

Submit Requirements:

Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Bo Wang (Gerrit)

unread,

Nov 14, 2025, 8:27:26 AMNov 14

to Crashpad LUCI CQ, Peng Zhou, Joshua Peraza, Mark Mentovai, Will Harris, crashp...@chromium.org

Attention needed from Joshua Peraza, Mark Mentovai and Will Harris

Bo Wang added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Bo Wang . resolved

Hi @w...@chromium.org @jpe...@chromium.org @ma...@chromium.org, gentle ping.
I’ve addressed all the comments, and the CL is ready for another review pass when you have a moment. Thanks!

unsatisfied_requirement

open

diffy

Bo Wang (Gerrit)

unread,

Nov 17, 2025, 3:50:37 AMNov 17

to Crashpad LUCI CQ, Peng Zhou, Joshua Peraza, Mark Mentovai, Will Harris, crashp...@chromium.org

Attention needed from Joshua Peraza, Mark Mentovai and Will Harris

Bo Wang added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Bo Wang . resolved

Hi @w...@chromium.org @jpe...@chromium.org @ma...@chromium.org, gentle ping.
I’ve addressed all the comments, and the CL is ready for another review pass when you have a moment. Thanks!

Bo Wang

Hi @w...@chromium.org @jpe...@chromium.org @ma...@chromium.org, just a friendly reminder.
The CL is ready for review/approval — please take a look when you get a chance. Thank you!

unsatisfied_requirement

open

diffy

Bo Wang (Gerrit)

unread,

Nov 18, 2025, 9:05:34 AMNov 18

to Crashpad LUCI CQ, Peng Zhou, Joshua Peraza, Mark Mentovai, Will Harris, crashp...@chromium.org

Attention needed from Mark Mentovai and Will Harris

Bo Wang added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Bo Wang . resolved

Hi @w...@chromium.org @jpe...@chromium.org @ma...@chromium.org, gentle ping.
I’ve addressed all the comments, and the CL is ready for another review pass when you have a moment. Thanks!

Bo Wang

Hi @w...@chromium.org @jpe...@chromium.org @ma...@chromium.org, just a friendly reminder.
The CL is ready for review/approval — please take a look when you get a chance. Thank you!

Bo Wang

Hi @w...@chromium.org @jpe...@chromium.org @ma...@chromium.org, just a quick reminder that the CL is ready for your review. Please take a look when you have a moment. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Mark Mentovai
Will Harris

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Joshua Peraza (Gerrit)

unread,

Nov 18, 2025, 11:35:38 AMNov 18

to Bo Wang, Crashpad LUCI CQ, Peng Zhou, Mark Mentovai, Will Harris, crashp...@chromium.org

Attention needed from Bo Wang, Mark Mentovai and Will Harris

Joshua Peraza added 1 comment

File tools/dump_minidump_annotations.cc

File-level comment, Patchset 2:

Mark Mentovai . resolved

I’m honestly surprised that we have this tool at all. This really is minidump_dump’s territory.

Joshua Peraza

I think this ended up here because we wanted to get at annotations for catapult on Windows and the minidump_dump target says it doesn't build on Windows and I already had it laying around.

Open in Gerrit

Related details

Attention is currently required from:

Bo Wang
Mark Mentovai
Will Harris

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Bo Wang (Gerrit)

unread,

Nov 19, 2025, 12:27:24 AMNov 19

to Crashpad LUCI CQ, Peng Zhou, Joshua Peraza, Mark Mentovai, Will Harris, crashp...@chromium.org

Attention needed from Joshua Peraza, Mark Mentovai and Will Harris

Bo Wang added 1 comment

File tools/dump_minidump_annotations.cc

File-level comment, Patchset 2:

Mark Mentovai . resolved

I’m honestly surprised that we have this tool at all. This really is minidump_dump’s territory.

Joshua Peraza

I think this ended up here because we wanted to get at annotations for catapult on Windows and the minidump_dump target says it doesn't build on Windows and I already had it laying around.

Bo Wang

@ma...@chromium.org @jpe...@chromium.org @w...@chromium.org Just to make sure I fully understand — does the current version look acceptable to land, or would you like me to make any further adjustments?

Open in Gerrit

Related details

Attention is currently required from:

Joshua Peraza
Mark Mentovai
Will Harris

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

open

diffy

Mark Mentovai (Gerrit)

unread,

Nov 20, 2025, 8:52:45 AMNov 20

to Bo Wang, Justin Cohen, Crashpad LUCI CQ, Peng Zhou, Joshua Peraza, crashp...@chromium.org

Attention needed from Bo Wang, Joshua Peraza and Justin Cohen

Mark Mentovai voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Bo Wang
Joshua Peraza
Justin Cohen

Submit Requirements:

Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Crashpad LUCI CQ (Gerrit)

unread,

Nov 20, 2025, 11:51:25 AMNov 20

to Bo Wang, Peng Zhou, Mark Mentovai, Justin Cohen, Joshua Peraza, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:

Add snapshot-level simple annotations output to dump_minidump_annotations

This CL enhances the dump_minidump_annotations tool to display
snapshot-level simple annotations in addition to the existing
module-level annotations. Previously, the tool only showed annotations
at the module level, but now it also outputs process-level annotations
from the snapshot's AnnotationsSimpleMap.

The change adds a new "Snapshot Annotations" section that displays
key-value pairs from the process snapshot, making it easier to
inspect process-wide annotations in minidump files.

Change-Id: I56a5df836cf4e845d6f81f8a7ba23ac71867362a

Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/7150658

Reviewed-by: Mark Mentovai <ma...@chromium.org>

Commit-Queue: Peng Zhou <zhoupe...@bytedance.com>

Reviewed-by: Peng Zhou <zhoupe...@bytedance.com>

Files:

M tools/dump_minidump_annotations.cc

Change size: XS

Delta: 1 file changed, 6 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Peng Zhou, +1 by Mark Mentovai

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Peng Zhou (Gerrit)

unread,

Nov 20, 2025, 12:45:45 PMNov 20

to Bo Wang, Mark Mentovai, Justin Cohen, Crashpad LUCI CQ, Joshua Peraza, crashp...@chromium.org

Attention needed from Bo Wang, Joshua Peraza and Justin Cohen

Peng Zhou voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Bo Wang
Joshua Peraza
Justin Cohen

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Peng Zhou (Gerrit)

unread,

Nov 20, 2025, 12:45:45 PMNov 20

to Bo Wang, Mark Mentovai, Justin Cohen, Crashpad LUCI CQ, Joshua Peraza, crashp...@chromium.org

Attention needed from Bo Wang, Joshua Peraza and Justin Cohen

Peng Zhou voted Commit-Queue+2

Commit-Queue

+2

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Add snapshot-level simple annotations output to dump_minidump_annotations [crashpad/crashpad : main]

Will Harris (Gerrit)

Will Harris added 1 comment

Related details

Mark Mentovai (Gerrit)

Mark Mentovai added 2 comments

Related details

Bo Wang (Gerrit)

Bo Wang added 2 comments

Related details

Bo Wang (Gerrit)

Bo Wang added 1 comment

Bo Wang (Gerrit)

Bo Wang added 1 comment

Bo Wang (Gerrit)

Bo Wang added 1 comment

Related details

Joshua Peraza (Gerrit)

Joshua Peraza added 1 comment

Related details

Bo Wang (Gerrit)

Bo Wang added 1 comment

Related details

Mark Mentovai (Gerrit)

Mark Mentovai voted Code-Review+1

Related details

Crashpad LUCI CQ (Gerrit)

Crashpad LUCI CQ submitted the change

Change information

Peng Zhou (Gerrit)

Peng Zhou voted Code-Review+1

Related details

Peng Zhou (Gerrit)

Peng Zhou voted Commit-Queue+2