Fix format issue [crashpad/crashpad : main]

0 views
Skip to first unread message

Arthur Wang (Gerrit)

unread,
May 15, 2024, 3:02:36 PMMay 15
to Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai

Arthur Wang added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Arthur Wang . resolved

when running update, chromium prompts to run git cl format, and this is the output
https://paste.googleplex.com/4561084619161600

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I9756fa76f94cfcb9edc9f8df8ecfa5ff33918c22
Gerrit-Change-Number: 5542412
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Wed, 15 May 2024 19:02:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
May 15, 2024, 3:04:41 PMMay 15
to Arthur Wang, crashp...@chromium.org
Attention needed from Arthur Wang

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Wang
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I9756fa76f94cfcb9edc9f8df8ecfa5ff33918c22
Gerrit-Change-Number: 5542412
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Arthur Wang <wuw...@chromium.org>
Gerrit-Comment-Date: Wed, 15 May 2024 19:04:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Arthur Wang (Gerrit)

unread,
May 15, 2024, 3:05:08 PMMay 15
to Mark Mentovai, crashp...@chromium.org

Arthur Wang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I9756fa76f94cfcb9edc9f8df8ecfa5ff33918c22
Gerrit-Change-Number: 5542412
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Wed, 15 May 2024 19:05:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
May 15, 2024, 3:43:33 PMMay 15
to Arthur Wang, Mark Mentovai, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:
Fix format issue
Change-Id: I9756fa76f94cfcb9edc9f8df8ecfa5ff33918c22
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Arthur Wang <wuw...@chromium.org>
Files:
  • M snapshot/mac/process_types.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I9756fa76f94cfcb9edc9f8df8ecfa5ff33918c22
Gerrit-Change-Number: 5542412
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Arthur Wang <wuw...@chromium.org>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages