Improve crashpad_ios_x64_dbg health [crashpad/crashpad : main]

2 views
Skip to first unread message

Victor Vianna (Gerrit)

unread,
Jan 21, 2026, 11:54:34 AM (11 days ago) Jan 21
to Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen

Victor Vianna added 1 comment

Patchset-level comments
File-level comment, Patchset 12 (Latest):
Victor Vianna . resolved

Disregard the red bot: it's still broken, as stated in the description

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Cohen
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If89d5a9f7543657fc065b5c53983499034b3e76b
Gerrit-Change-Number: 7274281
Gerrit-PatchSet: 12
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-Attention: Justin Cohen <justi...@chromium.org>
Gerrit-Comment-Date: Wed, 21 Jan 2026 16:54:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Victor Vianna (Gerrit)

unread,
Jan 21, 2026, 11:54:53 AM (11 days ago) Jan 21
to Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen

Victor Vianna added 1 comment

Patchset-level comments
Victor Vianna . resolved

Disregard the red bot: it's still broken, as stated in the description

Victor Vianna

Also, *.star changes don't take effect during dry-run anyway

Open in Gerrit

Related details

Attention is currently required from:
  • Justin Cohen
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If89d5a9f7543657fc065b5c53983499034b3e76b
Gerrit-Change-Number: 7274281
Gerrit-PatchSet: 12
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-Attention: Justin Cohen <justi...@chromium.org>
Gerrit-Comment-Date: Wed, 21 Jan 2026 16:54:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Victor Vianna <victor...@google.com>
unsatisfied_requirement
open
diffy

Justin Cohen (Gerrit)

unread,
Jan 21, 2026, 12:12:38 PM (11 days ago) Jan 21
to Victor Vianna, Will Yeager, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Victor Vianna

Justin Cohen voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If89d5a9f7543657fc065b5c53983499034b3e76b
Gerrit-Change-Number: 7274281
Gerrit-PatchSet: 12
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: Will Yeager <wye...@google.com>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Wed, 21 Jan 2026 17:12:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Victor Vianna (Gerrit)

unread,
Jan 21, 2026, 12:12:54 PM (11 days ago) Jan 21
to Justin Cohen, Will Yeager, Crashpad LUCI CQ, crashp...@chromium.org

Victor Vianna voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If89d5a9f7543657fc065b5c53983499034b3e76b
Gerrit-Change-Number: 7274281
Gerrit-PatchSet: 12
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: Will Yeager <wye...@google.com>
Gerrit-Comment-Date: Wed, 21 Jan 2026 17:12:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
Jan 21, 2026, 12:13:00 PM (11 days ago) Jan 21
to Victor Vianna, Justin Cohen, Will Yeager, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:
Improve crashpad_ios_x64_dbg health

This doesn't leave the bot green yet but at least it gets some (most?)
test suites passing. Note that was verified with `led`, not with
bot runs in this CL. This CL has No-Try because the bot is currently
broken.
Context:
- crbug.com/473850381#comment5
- crbug.com/473850381#comment9
No-Try: true
Bug: 388070065
Change-Id: If89d5a9f7543657fc065b5c53983499034b3e76b
Reviewed-by: Justin Cohen <justi...@chromium.org>
Commit-Queue: Victor Vianna <victor...@google.com>
Files:
  • M build/run_tests.py
  • M infra/config/generated/cr-buildbucket.cfg
  • M infra/config/generated/project.cfg
  • M infra/config/main.star
Change size: M
Delta: 4 files changed, 58 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Justin Cohen
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If89d5a9f7543657fc065b5c53983499034b3e76b
Gerrit-Change-Number: 7274281
Gerrit-PatchSet: 13
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: Will Yeager <wye...@google.com>
open
diffy
satisfied_requirement

Mark Mentovai (Gerrit)

unread,
Jan 21, 2026, 12:29:38 PM (11 days ago) Jan 21
to Crashpad LUCI CQ, Justin Cohen, Will Yeager, crashp...@chromium.org

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If89d5a9f7543657fc065b5c53983499034b3e76b
Gerrit-Change-Number: 7274281
Gerrit-PatchSet: 13
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: Will Yeager <wye...@google.com>
Gerrit-Comment-Date: Wed, 21 Jan 2026 17:29:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages