Add missing build/build_config.h includes [crashpad/crashpad : main]

5 views
Skip to first unread message

Mark Mentovai (Gerrit)

unread,
Aug 10, 2026, 7:49:51 PM (8 days ago) Aug 10
to Victor Vianna, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Victor Vianna

Mark Mentovai added 5 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Mark Mentovai . resolved

Crashpad allows an `#include` in a .h to satisfy a .cc’s need. Please revert the ones I’ve called out.

File snapshot/linux/exception_snapshot_linux_test.cc
Line 28, Patchset 3 (Latest):#include "build/build_config.h"
Mark Mentovai . unresolved

Already in the .h.

File snapshot/mac/cpu_context_mac_test.cc
Line 19, Patchset 3 (Latest):#include "build/build_config.h"
Mark Mentovai . unresolved

Already in the .h.

File snapshot/win/exception_snapshot_win_test.cc
Line 23, Patchset 3 (Latest):#include "build/build_config.h"
Mark Mentovai . unresolved

Already in the .h.

File util/numeric/int128_test.cc
Line 18, Patchset 3 (Latest):#include "build/build_config.h"
Mark Mentovai . unresolved

Already in the .h.

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I177bf6013b8ab36cf1615323ea5264ce444e2cce
Gerrit-Change-Number: 8234939
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Mon, 10 Aug 2026 23:49:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Victor Vianna (Gerrit)

unread,
Aug 10, 2026, 7:53:30 PM (8 days ago) Aug 10
to Mark Mentovai, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Mark Mentovai

Victor Vianna added 1 comment

Patchset-level comments
Mark Mentovai . unresolved

Crashpad allows an `#include` in a .h to satisfy a .cc’s need. Please revert the ones I’ve called out.

Victor Vianna

These are _test.cc files though and not the corresponding .cc ones. Does it still count? For reference, chromium doesn't accept that
https://source.chromium.org/chromium/chromium/src/+/main:PRESUBMIT.py;l=6504;drc=ab9a86c070d760baa33aa8d6d90101a6523795e4

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I177bf6013b8ab36cf1615323ea5264ce444e2cce
Gerrit-Change-Number: 8234939
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Mon, 10 Aug 2026 23:53:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mark Mentovai <ma...@chromium.org>
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Aug 10, 2026, 8:03:09 PM (8 days ago) Aug 10
to Victor Vianna, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Victor Vianna

Mark Mentovai voted and added 1 comment

Votes added by Mark Mentovai

Code-Review+1

1 comment

Patchset-level comments
Mark Mentovai . unresolved

Crashpad allows an `#include` in a .h to satisfy a .cc’s need. Please revert the ones I’ve called out.

Victor Vianna

These are _test.cc files though and not the corresponding .cc ones. Does it still count? For reference, chromium doesn't accept that
https://source.chromium.org/chromium/chromium/src/+/main:PRESUBMIT.py;l=6504;drc=ab9a86c070d760baa33aa8d6d90101a6523795e4

Mark Mentovai

Crashpad always has accepted this, yes.

But I guess it could interfere with a roll into Chromium, so LGTM.

(although if you didn't touch the files, the roll wouldn't see them!)

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I177bf6013b8ab36cf1615323ea5264ce444e2cce
Gerrit-Change-Number: 8234939
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Tue, 11 Aug 2026 00:03:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Mark Mentovai <ma...@chromium.org>
Comment-In-Reply-To: Victor Vianna <victor...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Victor Vianna (Gerrit)

unread,
Aug 10, 2026, 8:04:01 PM (8 days ago) Aug 10
to Mark Mentovai, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org

Victor Vianna added 6 comments

Patchset-level comments
Mark Mentovai . resolved

Crashpad allows an `#include` in a .h to satisfy a .cc’s need. Please revert the ones I’ve called out.

Victor Vianna

These are _test.cc files though and not the corresponding .cc ones. Does it still count? For reference, chromium doesn't accept that
https://source.chromium.org/chromium/chromium/src/+/main:PRESUBMIT.py;l=6504;drc=ab9a86c070d760baa33aa8d6d90101a6523795e4

Mark Mentovai

Crashpad always has accepted this, yes.

But I guess it could interfere with a roll into Chromium, so LGTM.

(although if you didn't touch the files, the roll wouldn't see them!)

Victor Vianna

Acknowledged

Victor Vianna . resolved

Thanks!

File snapshot/linux/exception_snapshot_linux_test.cc
Line 28, Patchset 3 (Latest):#include "build/build_config.h"
Mark Mentovai . resolved

Already in the .h.

Victor Vianna

Acknowledged

File snapshot/mac/cpu_context_mac_test.cc
Line 19, Patchset 3 (Latest):#include "build/build_config.h"
Mark Mentovai . resolved

Already in the .h.

Victor Vianna

Acknowledged

File snapshot/win/exception_snapshot_win_test.cc
Line 23, Patchset 3 (Latest):#include "build/build_config.h"
Mark Mentovai . resolved

Already in the .h.

Victor Vianna

Acknowledged

File util/numeric/int128_test.cc
Line 18, Patchset 3 (Latest):#include "build/build_config.h"
Mark Mentovai . resolved

Already in the .h.

Victor Vianna

Acknowledged

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: I177bf6013b8ab36cf1615323ea5264ce444e2cce
    Gerrit-Change-Number: 8234939
    Gerrit-PatchSet: 3
    Gerrit-Owner: Victor Vianna <victor...@google.com>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Reviewer: Victor Vianna <victor...@google.com>
    Gerrit-Comment-Date: Tue, 11 Aug 2026 00:03:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Victor Vianna (Gerrit)

    unread,
    Aug 10, 2026, 8:04:13 PM (8 days ago) Aug 10
    to Mark Mentovai, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org

    Victor Vianna submitted the change

    Change information

    Commit message:
    Add missing build/build_config.h includes

    These files were using ARCH_CPU_* macros but didn't include the proper
    header.

    Crashpad trybot failures are unrelated and tracked in
    https://crbug.com/544854901.
    Change-Id: I177bf6013b8ab36cf1615323ea5264ce444e2cce
    Reviewed-by: Mark Mentovai <ma...@chromium.org>
    Files:
    • M snapshot/fuchsia/process_snapshot_fuchsia_test.cc
    • M snapshot/linux/exception_snapshot_linux_test.cc
    • M snapshot/mac/cpu_context_mac_test.cc
    • M snapshot/win/exception_snapshot_win_test.cc
    • M util/linux/pac_helper.cc
    • M util/misc/capture_context_test_util_linux.cc
    • M util/misc/capture_context_test_util_mac.cc
    • M util/misc/capture_context_test_util_win.cc
    • M util/misc/reinterpret_bytes.cc
    • M util/numeric/int128_test.cc
    Change size: S
    Delta: 10 files changed, 10 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mark Mentovai
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: I177bf6013b8ab36cf1615323ea5264ce444e2cce
    Gerrit-Change-Number: 8234939
    Gerrit-PatchSet: 4
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages