mini_chromium: Remove Barrier_AtomicIncrement, no longer used [chromium/mini_chromium : main]
10 views
Skip to first unread message
Venkatesh Srinivas (Gerrit)
Sep 22, 2025, 3:42:05 PMSep 22
to crashp...@chromium.org
Message from Venkatesh Srinivas![]( "Open in Gerrit")
Set Ready For Review
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Sep 22, 2025, 4:40:43 PMSep 22
to Venkatesh Srinivas, Benoit Lize, crashp...@chromium.org
Attention needed from Benoit Lize and Venkatesh Srinivas
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Benoit Lize
- Venkatesh Srinivas
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Sep 25, 2025, 4:28:57 PMSep 25
to Venkatesh Srinivas, Benoit Lize, crashp...@chromium.org
Attention needed from Benoit Lize and Venkatesh Srinivas
Mark Mentovai added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Mark Mentovai . resolved
Benoit, can you Code-Review this so we can land it and include it in https://chromium-review.googlesource.com/c/6785253?
Related details
Attention is currently required from:
- Benoit Lize
- Venkatesh Srinivas
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benoit Lize (Gerrit)
Oct 6, 2025, 4:24:26 AMOct 6
to Venkatesh Srinivas, Mark Mentovai, crashp...@chromium.org
Attention needed from Venkatesh Srinivas
Benoit Lize voted and added 1 comment![]( "Open in Gerrit")
Votes added by Benoit Lize
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Venkatesh Srinivas
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Venkatesh Srinivas (Gerrit)
Oct 7, 2025, 1:03:59 PMOct 7
to Benoit Lize, Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai
Venkatesh Srinivas added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Mark Mentovai . unresolved
Benoit, can you Code-Review this so we can land it and include it in https://chromium-review.googlesource.com/c/6785253?
Venkatesh Srinivas
@ma...@chromium.org - Have both +2's, but it looks like I don't have permissions to submit to mini_chromium..
Related details
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Oct 7, 2025, 1:46:37 PMOct 7
to Venkatesh Srinivas, Benoit Lize, crashp...@chromium.org
Attention needed from Venkatesh Srinivas
Mark Mentovai added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Mark Mentovai . resolved
Venkatesh SrinivasBenoit, can you Code-Review this so we can land it and include it in https://chromium-review.googlesource.com/c/6785253?
@ma...@chromium.org - Have both +2's, but it looks like I don't have permissions to submit to mini_chromium..
Attention is currently required from:
- Venkatesh Srinivas
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Oct 7, 2025, 1:46:40 PMOct 7
to Venkatesh Srinivas, Benoit Lize, crashp...@chromium.org
Mark Mentovai submitted the change![]( "Open in Gerrit")
Change information
Commit message:
mini_chromium: Remove Barrier_AtomicIncrement, no longer used
The last user of Barrier_AtomicIncrement was crashpad_client_win.cc;
https://chromium-review.googlesource.com/c/crashpad/crashpad/+/6785253
removes the use, so we can remove the implementation.
Bug: 40175832
Change-Id: Id2884c37e1788bc471b02831885a6eb213824654
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Reviewed-by: Benoit Lize <li...@chromium.org>
Files:
- M base/atomicops.h
- M base/atomicops_internals_atomicword_compat.h
- M base/atomicops_internals_portable.h
Change size: S
Delta: 3 files changed, 0 insertions(+), 20 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Benoit Lize, +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages