remove references to goma [crashpad/crashpad : main]

1 view
Skip to first unread message

Takuto Ikuta (Gerrit)

unread,
Jun 5, 2024, 1:52:26 AMJun 5
to Takuto Ikuta, Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai

Takuto Ikuta voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ic82524205c7593ddba041c253e7d6283f9c89f33
Gerrit-Change-Number: 5599864
Gerrit-PatchSet: 2
Gerrit-Owner: Takuto Ikuta <tik...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Jun 2024 05:52:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Jun 5, 2024, 6:58:51 AMJun 5
to Takuto Ikuta, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Takuto Ikuta

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Takuto Ikuta
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ic82524205c7593ddba041c253e7d6283f9c89f33
Gerrit-Change-Number: 5599864
Gerrit-PatchSet: 3
Gerrit-Owner: Takuto Ikuta <tik...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
Gerrit-Attention: Takuto Ikuta <tik...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Jun 2024 10:58:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Takuto Ikuta (Gerrit)

unread,
Jun 5, 2024, 9:46:44 PMJun 5
to Takuto Ikuta, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Takuto Ikuta voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ic82524205c7593ddba041c253e7d6283f9c89f33
Gerrit-Change-Number: 5599864
Gerrit-PatchSet: 4
Gerrit-Owner: Takuto Ikuta <tik...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
Gerrit-Comment-Date: Thu, 06 Jun 2024 01:46:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
Jun 5, 2024, 9:46:50 PMJun 5
to Takuto Ikuta, Mark Mentovai, crashp...@chromium.org

Crashpad LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
remove references to goma

goma is not maintained anymore.
Bug: 41489832
Change-Id: Ic82524205c7593ddba041c253e7d6283f9c89f33
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Takuto Ikuta <tik...@chromium.org>
Files:
  • M build/ios/setup_ios_gn.config
Change size: XS
Delta: 1 file changed, 0 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ic82524205c7593ddba041c253e7d6283f9c89f33
Gerrit-Change-Number: 5599864
Gerrit-PatchSet: 5
Gerrit-Owner: Takuto Ikuta <tik...@chromium.org>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages