Fix crashpad_snapshot_test ProcessReaderMac.* for macOS ≥ 15.4 [crashpad/crashpad : main]
4 views
Skip to first unread message
Mark Mentovai (Gerrit)
Jul 28, 2025, 5:17:25 PMJul 28
to Joshua Peraza, Jesse McKenna, crashp...@chromium.org
Attention needed from Joshua Peraza
Mark Mentovai voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Joshua Peraza
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Jul 28, 2025, 5:21:23 PMJul 28
to Mark Mentovai, Crashpad LUCI CQ, Jesse McKenna, crashp...@chromium.org
Attention needed from Mark Mentovai
Joshua Peraza voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Jul 28, 2025, 6:52:32 PMJul 28
to Joshua Peraza, Crashpad LUCI CQ, Jesse McKenna, crashp...@chromium.org
Mark Mentovai voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Jul 28, 2025, 6:52:39 PMJul 28
to Mark Mentovai, Joshua Peraza, Jesse McKenna, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix crashpad_snapshot_test ProcessReaderMac.* for macOS ≥ 15.4
Starting in dyld-1284.13 (macOS 15.4), _dyld_get_image_name (in
dyld4::PrebuiltLoader::path) returns an absolute path for a main
executable, even when the image was not loaded from an absolute path.
This can break test expectations when the test executable is not invoked
from an absolute path. As a workaround, just use the main executable’s
basename for comparison purposes.
Change-Id: I3846d237a7a15e886cf15cd27146556103c22c2e
Reviewed-by: Joshua Peraza <jpe...@chromium.org>
Commit-Queue: Mark Mentovai <ma...@chromium.org>
Files:
- M snapshot/mac/process_reader_mac_test.cc
Change size: S
Delta: 1 file changed, 43 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joshua Peraza
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages