Inline kBackwardsClockTolerance in header [crashpad/crashpad : main]
6 views
Skip to first unread message
Jesse McKenna (Gerrit)
Oct 17, 2025, 8:12:03 PMOct 17
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Mark Mentovai
Jesse McKenna added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Oct 17, 2025, 8:39:24 PMOct 17
to Jesse McKenna, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Jesse McKenna
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Jesse McKenna
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jesse McKenna (Gerrit)
Oct 20, 2025, 1:27:43 PMOct 20
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
Jesse McKenna voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Oct 20, 2025, 1:39:51 PMOct 20
to Jesse McKenna, Mark Mentovai, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Inline kBackwardsClockTolerance in header
kBackwardsClockTolerance is in a header file, so it should be inlined to
ensure it's not duplicated across translation units.
This fixes the following Chromium presubmit warning:
Consider inlining constexpr variable definitions in headers outside of classes
to avoid unnecessary copies of the constant. See https://abseil.io/tips/168 for
more details.
third_party\crashpad\crashpad\handler\crash_report_upload_rate_limit.h: 29
constexpr int kBackwardsClockTolerance = 60 * 60 * 24; // 1 day
Bug: 42310127
Change-Id: Ie37ec72f62f5e3ee8c8080e5e1dd951a575e248a
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Jesse McKenna <jessem...@google.com>
Files:
- M handler/crash_report_upload_rate_limit.h
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages