ios: Use correct address when storing register memory. [crashpad/crashpad : cxx17]
1 view
Skip to first unread message
Justin Cohen (Gerrit)
Jun 14, 2024, 12:03:39 PMJun 14
to Ben Hamilton, crashp...@chromium.org
Attention needed from Ben Hamilton
Justin Cohen voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Ben Hamilton
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ben Hamilton (Gerrit)
Jun 14, 2024, 12:04:12 PMJun 14
to Justin Cohen, crashp...@chromium.org
Ben Hamilton submitted the change![]( "Open in Gerrit")
Change information
Commit message:
ios: Use correct address when storing register memory.
The memory region data saved in the intermediate dump is an address
offset by 128 bytes. However, the MemorySnapshot generated was using the
original address and not the offset address. The same data is being
captured in the minidump.
Change-Id: Ia34912c035319e79cf446a130e662084f4ab51ea
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5529059
Commit-Queue: Justin Cohen <justi...@chromium.org>
Reviewed-by: Joshua Peraza <jpe...@chromium.org>
Reviewed-by: Rohit Rao <rohi...@chromium.org>
(cherry picked from commit 371083179b7b3bc68dc8ff03ac235717805c78bd)
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/5632884
Reviewed-by: Justin Cohen <justi...@chromium.org>
Files:
- M client/ios_handler/in_process_intermediate_dump_handler.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/cxx17
Submit Requirements:
Code-Review: +1 by Justin Cohen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Jun 14, 2024, 1:41:07 PMJun 14
to Ben Hamilton, Justin Cohen, crashp...@chromium.org
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages