DEPS: fix version of fuchsia/sdk/core to avoid build error [crashpad/crashpad : main]

1 view
Skip to first unread message

Mark Mentovai (Gerrit)

unread,
Jun 5, 2024, 6:58:15 AMJun 5
to Takuto Ikuta, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Takuto Ikuta

Mark Mentovai voted and added 1 comment

Votes added by Mark Mentovai

Code-Review+1

1 comment

Commit Message
Line 9, Patchset 2 (Latest):This is a temporal workaround to avoid error like
Mark Mentovai . unresolved

temporary

Open in Gerrit

Related details

Attention is currently required from:
  • Takuto Ikuta
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ia5404b5d7a2f01f53211fba7b8d602b9236ccbd3
Gerrit-Change-Number: 5599904
Gerrit-PatchSet: 2
Gerrit-Owner: Takuto Ikuta <tik...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
Gerrit-Attention: Takuto Ikuta <tik...@chromium.org>
Gerrit-Comment-Date: Wed, 05 Jun 2024 10:58:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Takuto Ikuta (Gerrit)

unread,
Jun 5, 2024, 9:46:10 PMJun 5
to Takuto Ikuta, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Takuto Ikuta voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ia5404b5d7a2f01f53211fba7b8d602b9236ccbd3
Gerrit-Change-Number: 5599904
Gerrit-PatchSet: 4
Gerrit-Owner: Takuto Ikuta <tik...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
Gerrit-Comment-Date: Thu, 06 Jun 2024 01:46:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
Jun 5, 2024, 9:46:18 PMJun 5
to Takuto Ikuta, Mark Mentovai, crashp...@chromium.org

Crashpad LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
DEPS: fix version of fuchsia/sdk/core to avoid build error

This is a temporary workaround to avoid error like
https://ci.chromium.org/ui/p/crashpad/builders/try/crashpad_fuchsia_arm64_dbg/1299/overview
Bug: 41489832
Change-Id: Ia5404b5d7a2f01f53211fba7b8d602b9236ccbd3
Commit-Queue: Takuto Ikuta <tik...@chromium.org>
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
  • M DEPS
Change size: XS
Delta: 1 file changed, 4 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ia5404b5d7a2f01f53211fba7b8d602b9236ccbd3
Gerrit-Change-Number: 5599904
Gerrit-PatchSet: 5
Gerrit-Owner: Takuto Ikuta <tik...@chromium.org>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement

Takuto Ikuta (Gerrit)

unread,
Jun 5, 2024, 9:46:22 PMJun 5
to Takuto Ikuta, Crashpad LUCI CQ, Mark Mentovai, crashp...@chromium.org

Takuto Ikuta voted and added 1 comment

Votes added by Takuto Ikuta

Commit-Queue+2

1 comment

Commit Message
Line 9, Patchset 2:This is a temporal workaround to avoid error like
Mark Mentovai . resolved

temporary

Takuto Ikuta

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ia5404b5d7a2f01f53211fba7b8d602b9236ccbd3
Gerrit-Change-Number: 5599904
Gerrit-PatchSet: 4
Gerrit-Owner: Takuto Ikuta <tik...@chromium.org>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Takuto Ikuta <tik...@chromium.org>
Gerrit-Comment-Date: Thu, 06 Jun 2024 01:46:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Mark Mentovai <ma...@chromium.org>
satisfied_requirement
open
diffy

Takuto Ikuta (Gerrit)

unread,
Jun 5, 2024, 9:54:09 PMJun 5
to Crashpad LUCI CQ, Takuto Ikuta, Mark Mentovai, crashp...@chromium.org

Takuto Ikuta has created a revert of this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: revert
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ia5404b5d7a2f01f53211fba7b8d602b9236ccbd3
Gerrit-Change-Number: 5599904
Gerrit-PatchSet: 5
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages