Rename README.crashpad to .md [crashpad/crashpad : main]
Will Harris (Gerrit)
Will Harris added 1 comment![]( "Open in Gerrit")
hmm this file doesn't seem to contain any metadata, it's just a placeholder so the dir is created maybe?
Compare with https://chromium.googlesource.com/crashpad/crashpad/+/main/third_party/mini_chromium/README.crashpad which does seem to contain some valid metadata.
Is this correct? Perhaps mark@ knows more background on this.
Related details
- Jordan Brown
- Mark Mentovai
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Will Harris (Gerrit)
Will Harris added 1 comment![]( "Open in Gerrit")
hmm this file doesn't seem to contain any metadata, it's just a placeholder so the dir is created maybe?
Compare with https://chromium.googlesource.com/crashpad/crashpad/+/main/third_party/mini_chromium/README.crashpad which does seem to contain some valid metadata.
Is this correct? Perhaps mark@ knows more background on this.
Will HarrisYep, that's why we need to rename this one to .md
this discussion also took place in https://chromium-review.googlesource.com/c/chromium/src/+/6966151
I'm going to recuse myself until mark@ has lgtmed then I will happily rs lgtm to get the second lgtm
Related details
- Mark Mentovai
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jordan Brown (Gerrit)
Jordan Brown added 2 comments![]( "Open in Gerrit")
Jordan Browncan you explain why this is needed or link a bug?
Done
Renaming README.crashpad to .mdJordan Brownwe prefer imperative mood for CL titles
can you change to "Rename ..." instead of "Renaming ..."
Done
Related details
- Mark Mentovai
- Will Harris
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jordan Brown (Gerrit)
Jordan Brown added 1 comment![]( "Open in Gerrit")
Jordan Brownhmm this file doesn't seem to contain any metadata, it's just a placeholder so the dir is created maybe?
Compare with https://chromium.googlesource.com/crashpad/crashpad/+/main/third_party/mini_chromium/README.crashpad which does seem to contain some valid metadata.
Is this correct? Perhaps mark@ knows more background on this.
Yep, that's why we need to rename this one to .md
Related details
- Mark Mentovai
- Will Harris
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jordan Brown (Gerrit)
Jordan Brown added 1 comment![]( "Open in Gerrit")
Jordan Brownhmm this file doesn't seem to contain any metadata, it's just a placeholder so the dir is created maybe?
Compare with https://chromium.googlesource.com/crashpad/crashpad/+/main/third_party/mini_chromium/README.crashpad which does seem to contain some valid metadata.
Is this correct? Perhaps mark@ knows more background on this.
Yep, that's why we need to rename this one to .md
this discussion also took place in https://chromium-review.googlesource.com/c/chromium/src/+/6966151
I'm going to recuse myself until mark@ has lgtmed then I will happily rs lgtm to get the second lgtm
Acknowledged
Related details
- Mark Mentovai
- Will Harris
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |