Add missing include to crashpad. [crashpad/crashpad : main]
6 views
Skip to first unread message
Mark Mentovai (Gerrit)
May 14, 2025, 6:59:15 AM5/14/25
to Matt Stark, Joshua Peraza, crashp...@chromium.org
Attention needed from Joshua Peraza and Matt Stark
Mark Mentovai voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Mentovai
| Code-Review | +1 |
1 comment
File util/stdlib/strlcpy.h
Line 18, Patchset 1 (Latest):
#include <sys/types.h>Mark Mentovai . unresolved
Optional, but you can remove this. It's here for `size_t`, but `<uchar.h>` is also defined as providing that type.
Related details
Attention is currently required from:
- Joshua Peraza
- Matt Stark
Submit Requirements:
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Stark (Gerrit)
May 14, 2025, 8:58:24 PM5/14/25
to Takuto Ikuta, Mark Mentovai, Joshua Peraza, crashp...@chromium.org
Attention needed from Joshua Peraza and Takuto Ikuta
Matt Stark added 1 comment![]( "Open in Gerrit")
File util/stdlib/strlcpy.h
Line 18, Patchset 1 (Latest):
#include <sys/types.h>Mark Mentovai . resolved
Optional, but you can remove this. It's here for `size_t`, but `<uchar.h>` is also defined as providing that type.
Attention is currently required from:
- Joshua Peraza
- Takuto Ikuta
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takuto Ikuta (Gerrit)
May 14, 2025, 10:28:21 PM5/14/25
to Matt Stark, Takuto Ikuta, Mark Mentovai, Joshua Peraza, crashp...@chromium.org
Attention needed from Joshua Peraza and Matt Stark
Takuto Ikuta voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joshua Peraza
- Matt Stark
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Matt Stark (Gerrit)
May 14, 2025, 11:17:13 PM5/14/25
to Takuto Ikuta, Mark Mentovai, crashp...@chromium.org
Matt Stark voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
May 14, 2025, 11:26:37 PM5/14/25
to Matt Stark, Takuto Ikuta, Mark Mentovai, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add missing include to crashpad.
char16_t is defined in uchar.h
Change-Id: I568beb00fe41ec78170e700e324845877b680deb
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Reviewed-by: Takuto Ikuta <tik...@chromium.org>
Commit-Queue: Matt Stark <ms...@google.com>
Files:
- M util/stdlib/strlcpy.h
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai, +1 by Takuto Ikuta
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages