linux: Add PT_GNU_STACK to synthesized test module ELF [crashpad/crashpad : main]
10 views
Skip to first unread message
Will Harris (Gerrit)
Apr 20, 2026, 12:30:14 PM (4 days ago) Apr 20
to utzcoz, Matthew Denton, Joshua Peraza, crashp...@chromium.org, Will Harris
Attention needed from Joshua Peraza and Matthew Denton
Will Harris added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Will Harris . resolved
I am not qualified to review this. adding mpdenton
Related details
Attention is currently required from:
- Joshua Peraza
- Matthew Denton
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Apr 20, 2026, 4:49:22 PM (4 days ago) Apr 20
to utzcoz, Matthew Denton, Joshua Peraza, crashp...@chromium.org
Attention needed from Joshua Peraza, Matthew Denton and utzcoz
Mark Mentovai added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Will Harris . resolved
I am not qualified to review this. adding mpdenton
Mark Mentovai
I am not qualified to review this. adding mpdenton
Attention is currently required from:
- Joshua Peraza
- Matthew Denton
- utzcoz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Apr 20, 2026, 6:11:03 PM (4 days ago) Apr 20
to utzcoz, Mark Mentovai, Matthew Denton, crashp...@chromium.org
Attention needed from Matthew Denton and utzcoz
Joshua Peraza added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Joshua Peraza . resolved
Thanks for the patch!
Commit Message
Joshua Peraza . unresolved
The commit message should wrap at 72 characters.
Line 26, Patchset 3 (Latest):
Bug: N/AJoshua Peraza . unresolved
Don't include a bug line if there is no bug.
See docs on commit message formatting: https://chromium.googlesource.com/chromium/src/+/HEAD/agents/skills/cl-description/cl-description.md
Related details
Attention is currently required from:
- Matthew Denton
- utzcoz
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
utzcoz (Gerrit)
Apr 21, 2026, 10:46:28 AM (4 days ago) Apr 21
to Mark Mentovai, Matthew Denton, Joshua Peraza, crashp...@chromium.org
Attention needed from Joshua Peraza and Matthew Denton
utzcoz added 2 comments![]( "Open in Gerrit")
Commit Message
The commit message should wrap at 72 characters.
utzcoz
Updated.
Don't include a bug line if there is no bug.
See docs on commit message formatting: https://chromium.googlesource.com/chromium/src/+/HEAD/agents/skills/cl-description/cl-description.md
Attention is currently required from:
- Joshua Peraza
- Matthew Denton
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Apr 21, 2026, 11:45:11 AM (3 days ago) Apr 21
to utzcoz, Mark Mentovai, Matthew Denton, crashp...@chromium.org
Attention needed from Matthew Denton and utzcoz
Joshua Peraza voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Matthew Denton
- utzcoz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
utzcoz (Gerrit)
Apr 21, 2026, 12:14:31 PM (3 days ago) Apr 21
to Joshua Peraza, Mark Mentovai, Matthew Denton, crashp...@chromium.org
Attention needed from Matthew Denton
utzcoz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Matthew Denton
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Apr 21, 2026, 12:16:40 PM (3 days ago) Apr 21
to utzcoz, Joshua Peraza, Matthew Denton, crashp...@chromium.org
Attention needed from Matthew Denton and utzcoz
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Matthew Denton
- utzcoz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
utzcoz (Gerrit)
Apr 21, 2026, 9:47:45 PM (3 days ago) Apr 21
to crashpa...@luci-project-accounts.iam.gserviceaccount.com, Mark Mentovai, Joshua Peraza, Matthew Denton, crashp...@chromium.org
Attention needed from Matthew Denton
utzcoz voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Matthew Denton
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
utzcoz (Gerrit)
Apr 21, 2026, 9:48:42 PM (3 days ago) Apr 21
to crashpa...@luci-project-accounts.iam.gserviceaccount.com, Mark Mentovai, Joshua Peraza, Matthew Denton, crashp...@chromium.org
Attention needed from Matthew Denton
utzcoz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
utzcoz . resolved
Thanks for reviewing, could you help to submit it? Thanks.
Related details
Attention is currently required from:
- Matthew Denton
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Apr 22, 2026, 9:06:45 AM (3 days ago) Apr 22
to utzcoz, crashpa...@luci-project-accounts.iam.gserviceaccount.com, Joshua Peraza, Matthew Denton, crashp...@chromium.org
Attention needed from Matthew Denton and utzcoz
Mark Mentovai voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Matthew Denton
- utzcoz
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
crashpad-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Apr 22, 2026, 10:54:34 AM (2 days ago) Apr 22
to utzcoz, Mark Mentovai, Joshua Peraza, Matthew Denton, crashp...@chromium.org
crashpa...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
linux: Add PT_GNU_STACK to synthesized test module ELF
The DebugRendezvous.Self, ProcessReaderLinux.SelfModules, and
ProcessReaderLinux.ChildModules tests synthesize a minimal shared
object in memory and dlopen it. The generated ELF had no
PT_GNU_STACK program header, so glibc's loader treated it as
requiring an executable stack and asked the kernel to mark the
stack executable. Recent Linux kernels refuse that request,
causing dlopen to fail with "cannot enable executable stack as
shared object requires: Invalid argument".
Add a PT_GNU_STACK phdr with PF_R | PF_W so the loader knows
the module does not need an executable stack. e_phnum is
auto-derived from sizeof(phdr_table), so no other bookkeeping
is needed.
This is backwards-compatible: PT_GNU_STACK has been honored by
Linux, glibc, and binutils since ~2003 (Linux 2.6, glibc 2.3.3),
and loaders that do not recognize the OS-specific phdr type simply
ignore it. Declaring non-exec is strictly safer on both old and
new kernels.
Change-Id: I2c3ed968eaa6841725737a8c337c148300115e69
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Reviewed-by: Joshua Peraza <jpe...@chromium.org>
Commit-Queue: Mark Mentovai <ma...@chromium.org>
Files:
- M snapshot/linux/test_modules.cc
Change size: XS
Delta: 1 file changed, 7 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joshua Peraza, +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages