Fix data race in WorkerThread::running_ [crashpad/crashpad : main]
2 views
Skip to first unread message
Justin Cohen (Gerrit)
Mar 6, 2026, 4:08:15 PM (8 days ago) Mar 6
to Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai
Justin Cohen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Mar 6, 2026, 4:25:17 PM (8 days ago) Mar 6
to Justin Cohen, Mark Mentovai, crashp...@chromium.org
Attention needed from Justin Cohen and Mark Mentovai
Mark Mentovai voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Mentovai
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Justin Cohen
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Mar 6, 2026, 8:50:28 PM (8 days ago) Mar 6
to Mark Mentovai, Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai
Justin Cohen voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Mar 6, 2026, 9:25:32 PM (8 days ago) Mar 6
to Justin Cohen, Mark Mentovai, Mark Mentovai, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix data race in WorkerThread::running_
WorkerThread::running_ is accessed from both the main thread (during
Start() and Stop()) and the worker thread (in
WorkerThreadImpl::ThreadMain()). Since these accesses were not
synchronized, ThreadSanitizer (TSAN) detected a data race during
WorkerThread/Restart tests.
This change converts running_ to std::atomic_bool to ensure thread-safe
access across threads.
- Verified by running crashpad/util:util_ios_test with TSAN enabled.
Change-Id: I03a360dfe41354881972c18409854d08b764e872
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Justin Cohen <justi...@google.com>
Files:
- M util/thread/worker_thread.h
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages