Compile as C++17 by using -std=c++17 (and /std:c++17 on Windows) [chromium/mini_chromium : main]
Mark Mentovai (Gerrit)
Attention is currently required from: Roland Bock.
2 comments:
Patchset:
rbock: This is the follow-up to https://chromium-review.googlesource.com/c/3369368, and a prerequisite to landing an un-abandoned https://chromium-review.googlesource.com/c/3370128.
File build/config/BUILD.gn:
Patch Set #1, Line 258:
cflags_cc = [ "/std:c++17" ]ajgo: I wanted to set cflags_c to "/std:c11" here too, as we do for non-Windows above, but this triggers C5105 in the SDK. https://developercommunity2.visualstudio.com/t/std:c17-generates-warning-compiling-Win/1249671 says that this is fixed in SDK 10.0.20348.0, but you just updated us (on the eighth try…and thanks again!) to 10.0.19041.0. I don’t see a newer SDK than that. scottmg had been doing these uploads, and he’s gone now. Do you know if the process to package up a new SDK is documented anywhere?
To view, visit change 3370863. To unsubscribe, or for help writing mail filters, visit settings.
Roland Bock (Gerrit)
Attention is currently required from: Mark Mentovai.
1 comment:
Patchset:
To view, visit change 3370863. To unsubscribe, or for help writing mail filters, visit settings.
Mark Mentovai (Gerrit)
Attention is currently required from: Joshua Peraza.
1 comment:
File build/config/BUILD.gn:
Patch Set #1, Line 258:
cflags_cc = [ "/std:c++17" ]ajgo: I wanted to set cflags_c to "/std:c11" here too, as we do for non-Windows above, but this triggers C5105 in the SDK. https://developercommunity2.visualstudio.com/t/std:c17-generates-warning-compiling-Win/1249671 says that this is fixed in SDK 10.0.20348.0, but you just updated us (on the eighth try…and thanks again!) to 10.0.19041.0. I don’t see a newer SDK than that. scottmg had been doing these uploads, and he’s gone now. Do you know if the process to package up a new SDK is documented anywhere?
To view, visit change 3370863. To unsubscribe, or for help writing mail filters, visit settings.
Alex Gough (Gerrit)
Attention is currently required from: Joshua Peraza, Mark Mentovai.
1 comment:
File build/config/BUILD.gn:
Patch Set #1, Line 258:
cflags_cc = [ "/std:c++17" ]
> ajgo: I wanted to set cflags_c to "/std:c11" here too, as we do for non-Windows above, but this tr […]
I think the steps here: go/windows-sdk-cipd-update
Hopefully it will produce a package in the layout that my fiddling now accepts.
Possible spoiler - the Chromium SDK is 10.0.19041 or later - https://chromium.googlesource.com/chromium/src.git/+/refs/heads/main/docs/windows_build_instructions.md
To view, visit change 3370863. To unsubscribe, or for help writing mail filters, visit settings.
Mark Mentovai (Gerrit)
Attention is currently required from: Alex Gough, Joshua Peraza.
1 comment:
File build/config/BUILD.gn:
Patch Set #1, Line 258:
cflags_cc = [ "/std:c++17" ]
I think the steps here: go/windows-sdk-cipd-update
Hopefully it will produce a package in the layout that my fiddling now accepts.
Possible spoiler - the Chromium SDK is 10.0.19041 or later - https://chromium.googlesource.com/chromium/src.git/+/refs/heads/main/docs/windows_build_instructions.md
Shouldn't be a spoiler for two reasons. Chromium doesn't pick up mini_chromium's settings, but also, it builds with clang-cl instead of MSVC cl.
To view, visit change 3370863. To unsubscribe, or for help writing mail filters, visit settings.
Joshua Peraza (Gerrit)
Attention is currently required from: Alex Gough, Mark Mentovai.
Patch set 1:Code-Review +1
Alex Gough (Gerrit)
Attention is currently required from: Mark Mentovai.
1 comment:
File build/config/BUILD.gn:
Patch Set #1, Line 258:
cflags_cc = [ "/std:c++17" ]
I took a quick look at:
go/windows-sdk-cipd-update
and to make things difficult - the version listed currently in vs_toolchain.py is 3bda71a11e == 19041 and is the latest dated archive in `gsutil ls -L gs://chrome-wintoolchain/` so you might also need to follow:
go/chromium-msvc-toolchain - I think brucedawson is the best person to check with.
To view, visit change 3370863. To unsubscribe, or for help writing mail filters, visit settings.
Mark Mentovai (Gerrit)
Mark Mentovai submitted this change.
Compile as C++17 by using -std=c++17 (and /std:c++17 on Windows)
Change-Id: Ifc583488496a05a18e3611984798d26250fe8e42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/3370863
Reviewed-by: Joshua Peraza <jpe...@chromium.org>
---
M build/config/BUILD.gn
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn
index d6171ef..d014759 100644
--- a/build/config/BUILD.gn
+++ b/build/config/BUILD.gn
@@ -153,7 +153,7 @@
]
cflags_c = [ "-std=c11" ]
- cflags_cc = [ "-std=c++14" ]
+ cflags_cc = [ "-std=c++17" ]
cflags_objc = cflags_c
cflags_objcc = cflags_cc
@@ -255,6 +255,8 @@
"/wd4996", # 'X' was declared deprecated.
]
+ cflags_cc = [ "/std:c++17" ]
+
ldflags += [ "/DEBUG" ]
libs = [ "kernel32.lib" ]
To view, visit change 3370863. To unsubscribe, or for help writing mail filters, visit settings.