crashpad: Convert legacy atomics -> std::atomic<> [crashpad/crashpad : main]

9 views
Skip to first unread message

Venkatesh Srinivas (Gerrit)

unread,
Jul 24, 2025, 7:08:34 PMJul 24
to Mark Mentovai, Benoit Lize, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Benoit Lize and Mark Mentovai

Venkatesh Srinivas added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Venkatesh Srinivas . resolved

https://chromium-review.googlesource.com/c/chromium/src/+/6598917 removes Barrier_AtomicIncrement; I missed that crashpad used it - my initial test runs didn't cover crashpad. Removing here.

Open in Gerrit

Related details

Attention is currently required from:
  • Benoit Lize
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ida2e035ff67b1be5ec825e446e16e9c1e0780b46
Gerrit-Change-Number: 6785253
Gerrit-PatchSet: 1
Gerrit-Owner: Venkatesh Srinivas <venka...@chromium.org>
Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Venkatesh Srinivas <venka...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Benoit Lize <li...@chromium.org>
Gerrit-Comment-Date: Thu, 24 Jul 2025 21:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Jul 24, 2025, 7:11:04 PMJul 24
to Venkatesh Srinivas, Benoit Lize, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Benoit Lize and Venkatesh Srinivas

Mark Mentovai added 1 comment

Patchset-level comments
Venkatesh Srinivas . unresolved

https://chromium-review.googlesource.com/c/chromium/src/+/6598917 removes Barrier_AtomicIncrement; I missed that crashpad used it - my initial test runs didn't cover crashpad. Removing here.

Mark Mentovai

https://chromium-review.googlesource.com/c/chromium/src/+/6598917 removes Barrier_AtomicIncrement; I missed that crashpad used it - my initial test runs didn't cover crashpad. Removing here.

You'll also need to remove it from mini_chromium in a separate change and then roll that in here.

Open in Gerrit

Related details

Attention is currently required from:
  • Benoit Lize
  • Venkatesh Srinivas
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Ida2e035ff67b1be5ec825e446e16e9c1e0780b46
    Gerrit-Change-Number: 6785253
    Gerrit-PatchSet: 1
    Gerrit-Owner: Venkatesh Srinivas <venka...@chromium.org>
    Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Reviewer: Venkatesh Srinivas <venka...@chromium.org>
    Gerrit-Attention: Venkatesh Srinivas <venka...@chromium.org>
    Gerrit-Attention: Benoit Lize <li...@chromium.org>
    Gerrit-Comment-Date: Thu, 24 Jul 2025 23:11:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Venkatesh Srinivas <venka...@chromium.org>
    unsatisfied_requirement
    open
    diffy

    Benoit Lize (Gerrit)

    unread,
    Jul 28, 2025, 9:49:54 AMJul 28
    to Venkatesh Srinivas, Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org
    Attention needed from Venkatesh Srinivas

    Benoit Lize voted and added 1 comment

    Votes added by Benoit Lize

    Code-Review+1

    1 comment

    Patchset-level comments
    Benoit Lize . resolved

    lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Venkatesh Srinivas
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: Ida2e035ff67b1be5ec825e446e16e9c1e0780b46
    Gerrit-Change-Number: 6785253
    Gerrit-PatchSet: 1
    Gerrit-Owner: Venkatesh Srinivas <venka...@chromium.org>
    Gerrit-Reviewer: Benoit Lize <li...@chromium.org>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Reviewer: Venkatesh Srinivas <venka...@chromium.org>
    Gerrit-Attention: Venkatesh Srinivas <venka...@chromium.org>
    Gerrit-Comment-Date: Mon, 28 Jul 2025 12:48:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages