Add cpp-httplib local modification for BoringSSL compatibility [crashpad/crashpad : main]

4 views

Skip to first unread message

Justin Cohen (Gerrit)

unread,

Feb 10, 2026, 10:23:26 PM (12 days ago) Feb 10

to Mark Mentovai, Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org

Attention needed from Joshua Peraza

Justin Cohen voted and added 2 comments

Votes added by Justin Cohen

Commit-Queue

2 comments

Commit Message

Line 7, Patchset 7:Add cpp-httplib local modification to correct sign comparison error.

Mark Mentovai . resolved

I think “BoringSSL compatibility” is more important and belongs here in the summary line. You should still talk about -Wsign-compare below, but there are only so many things you can fit in the first line.

Justin Cohen

Done

File third_party/cpp-httplib/README.crashpad

Line 28, Patchset 7: - Correct sign compare error in sk_X509_OBJECT_num.

Mark Mentovai . resolved

Say that this is for BoringSSL compatibility.

Justin Cohen

Done

Open in Gerrit

Related details

Attention is currently required from:

Joshua Peraza

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Crashpad LUCI CQ (Gerrit)

unread,

Feb 10, 2026, 10:35:10 PM (12 days ago) Feb 10

to Justin Cohen, Mark Mentovai, Joshua Peraza, crashp...@chromium.org

Crashpad LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: third_party/cpp-httplib/README.crashpad
Insertions: 1, Deletions: 1.

@@ -25,4 +25,4 @@
     - fbee136dca54 Fix #2193. Allow _WIN32
     - dffce89514c2 Fix 32-bit MSVC compiler error due to unknown command
                    #warning (#2202)
- - Correct sign compare error in sk_X509_OBJECT_num.
+ - Fix sign compare error with sk_X509_OBJECT_num from BoringSSL.
```

Change information

Commit message:

Add cpp-httplib local modification for BoringSSL compatibility

In some build configurations, sk_X509_OBJECT_num (from BoringSSL)
returns a size_t. Comparing this directly against a signed int loop
counter triggers -Werror,-Wsign-compare.

This patch moves the count into a local int variable so the compiler
uses implicit conversion to ensure type consistency during the loop
comparison.

Upstream pull request created here:
  https://github.com/yhirose/cpp-httplib/pull/2355

Full error: In file included from
../../third_party/crashpad/crashpad/util/net/http_transport_test_server.cc:42:
../../third_party/crashpad/crashpad/third_party/cpp-httplib/cpp-httplib/httplib.h:10923:21:
error: comparison of integers of different signs: 'int' and 'size_t'
(aka 'unsigned long') [-Werror,-Wsign-compare]
 10923 |   for (int i = 0; i < sk_X509_OBJECT_num(objs); i++) {
       |                   ~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated from:
https://ci.chromium.org/ui/p/chromium/builders/try/linux-chromeos-compile-dbg/2519055/overview

Change-Id: If24ef33b3838bf90e1f1c79a3869892aa9209c7c

Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/7563115

Reviewed-by: Mark Mentovai <ma...@chromium.org>

Commit-Queue: Justin Cohen <justi...@google.com>

Files:

M third_party/cpp-httplib/README.crashpad
M third_party/cpp-httplib/cpp-httplib/httplib.h

Change size: XS

Delta: 2 files changed, 3 insertions(+), 1 deletion(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Mark Mentovai

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages