ios: Suppress log-if-missing for kSourceVersion intermediate dump key. [crashpad/crashpad : main]

Justin Cohen (Gerrit)

unread,

Feb 27, 2023, 3:51:06 PM2/27/23

to Mark Mentovai, crashp...@chromium.org

Attention is currently required from: Mark Mentovai.

Patch set 1:Commit-Queue +1

View Change

To view, visit change 4294861. To unsubscribe, or for help writing mail filters, visit settings.

Mark Mentovai (Gerrit)

unread,

Feb 27, 2023, 3:59:47 PM2/27/23

to Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org

Attention is currently required from: Justin Cohen.

Patch set 1:Code-Review +1

View Change

To view, visit change 4294861. To unsubscribe, or for help writing mail filters, visit settings.

Justin Cohen (Gerrit)

unread,

Feb 27, 2023, 4:08:18 PM2/27/23

to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Attention is currently required from: Justin Cohen.

Patch set 1:Commit-Queue +2

View Change

To view, visit change 4294861. To unsubscribe, or for help writing mail filters, visit settings.

Crashpad LUCI CQ (Gerrit)

unread,

Feb 27, 2023, 4:08:28 PM2/27/23

to Justin Cohen, Mark Mentovai, crashp...@chromium.org

Crashpad LUCI CQ submitted this change.

View Change

Approvals:
  Justin Cohen: Commit
  Mark Mentovai: Looks good to me

ios: Suppress log-if-missing for kSourceVersion intermediate dump key.

It's not required that LC_SOURCE_VERSION be present in every module, and
common for it to be missing. Suppress recording its absence.

Fixed: crashpad:443
Change-Id: Iae10c38c78514e78af6c3176cc809d95a3ae3811
Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4294861
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Justin Cohen <justi...@chromium.org>
---
M snapshot/ios/module_snapshot_ios_intermediate_dump.cc
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/snapshot/ios/module_snapshot_ios_intermediate_dump.cc b/snapshot/ios/module_snapshot_ios_intermediate_dump.cc
index 39d3bab..44c8c20 100644
--- a/snapshot/ios/module_snapshot_ios_intermediate_dump.cc
+++ b/snapshot/ios/module_snapshot_ios_intermediate_dump.cc
@@ -51,11 +51,14 @@
   GetDataStringFromMap(image_data, Key::kName, &name_);
   GetDataValueFromMap(image_data, Key::kAddress, &address_);
   GetDataValueFromMap(image_data, Key::kSize, &size_);
-  GetDataValueFromMap(image_data, Key::kSourceVersion, &source_version_);
   GetDataValueFromMap(image_data, Key::kFileType, &filetype_);
 
   // These keys are often missing.
   GetDataValueFromMap(image_data,
+                      Key::kSourceVersion,
+                      &source_version_,
+                      LogMissingDataValueFromMap::kDontLogIfMissing);
+  GetDataValueFromMap(image_data,
                       Key::kTimestamp,
                       &timestamp_,
                       LogMissingDataValueFromMap::kDontLogIfMissing);

To view, visit change 4294861. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward