Fix Fuchsia roller [crashpad/crashpad : main]

3 views
Skip to first unread message

Avi Drissman (Gerrit)

unread,
May 29, 2025, 11:37:28 AMMay 29
to Thomas Gales, Avi Drissman, Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai and Thomas Gales

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Avi Drissman . resolved

LG, though I am not owner here.

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
  • Thomas Gales
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If95134e3c8202024359051ce61fb1c870a2734ed
Gerrit-Change-Number: 6602453
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Gales <tga...@google.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Thomas Gales <tga...@google.com>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Thu, 29 May 2025 15:37:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Thomas Gales (Gerrit)

unread,
May 29, 2025, 11:38:55 AMMay 29
to Avi Drissman, Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai

Thomas Gales added 1 comment

Patchset-level comments
Avi Drissman . resolved

LG, though I am not owner here.

Thomas Gales

Thanks. Needed 2 Chromium reviewers since I'm not an official committer.

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: If95134e3c8202024359051ce61fb1c870a2734ed
Gerrit-Change-Number: 6602453
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Gales <tga...@google.com>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Thu, 29 May 2025 15:38:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Avi Drissman <a...@chromium.org>
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
May 29, 2025, 12:15:06 PMMay 29
to Thomas Gales, Avi Drissman, crashp...@chromium.org
Attention needed from Thomas Gales

Mark Mentovai added 2 comments

Commit Message
Line 7, Patchset 3 (Latest):Fix Fuchsia roller
Mark Mentovai . unresolved

This fixes the Fuchsia build. The roller is an implementation detail.

Line 12, Patchset 3 (Latest):Bug: chromium:40173260
Mark Mentovai . unresolved

Crashpad and Chromium share a bug namespace now, so the chromium: prefix isn’t necessary.

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Gales
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: crashpad/crashpad
    Gerrit-Branch: main
    Gerrit-Change-Id: If95134e3c8202024359051ce61fb1c870a2734ed
    Gerrit-Change-Number: 6602453
    Gerrit-PatchSet: 3
    Gerrit-Owner: Thomas Gales <tga...@google.com>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
    Gerrit-Attention: Thomas Gales <tga...@google.com>
    Gerrit-Comment-Date: Thu, 29 May 2025 16:15:03 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages