Fix NDK path for llvm-ar. Bump android_api_level 21 -> 26 (Oreo) [chromium/mini_chromium : main]

9 views
Skip to first unread message

Andrew Grieve (Gerrit)

unread,
Jun 1, 2026, 8:18:40 PM (4 days ago) Jun 1
to Andrew Grieve, Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai

Andrew Grieve added 1 comment

Commit Message
Line 7, Patchset 1:Fix NDK path for llvm-ar, and bump android_api_level 21 -> 26
Mark Mentovai . resolved

Can you say in the commit message which Android version these SDK levels correspond to?

Andrew Grieve

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/mini_chromium
Gerrit-Branch: main
Gerrit-Change-Id: I898802e06c3366b2d01be17380a00ac2f889a7d0
Gerrit-Change-Number: 7883584
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Jun 2026 19:58:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mark Mentovai <ma...@chromium.org>
unsatisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Jun 1, 2026, 8:18:40 PM (4 days ago) Jun 1
to Andrew Grieve, Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai

Andrew Grieve added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/mini_chromium
Gerrit-Branch: main
Gerrit-Change-Id: I898802e06c3366b2d01be17380a00ac2f889a7d0
Gerrit-Change-Number: 7883584
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Jun 2026 21:43:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Jun 1, 2026, 8:19:13 PM (4 days ago) Jun 1
to Andrew Grieve, crashp...@chromium.org
Attention needed from Andrew Grieve

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/mini_chromium
Gerrit-Branch: main
Gerrit-Change-Id: I898802e06c3366b2d01be17380a00ac2f889a7d0
Gerrit-Change-Number: 7883584
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jun 2026 00:19:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
Jun 1, 2026, 8:19:33 PM (4 days ago) Jun 1
to Andrew Grieve, crashp...@chromium.org

Mark Mentovai submitted the change

Change information

Commit message:
Fix NDK path for llvm-ar. Bump android_api_level 21 -> 26 (Oreo)

Note: Chrome's minSdkVersion is 29 (Q), so this is given an extra 2
years of Android support vs. Chrome.
Change-Id: I898802e06c3366b2d01be17380a00ac2f889a7d0
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
  • M build/config/BUILD.gn
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/mini_chromium
Gerrit-Branch: main
Gerrit-Change-Id: I898802e06c3366b2d01be17380a00ac2f889a7d0
Gerrit-Change-Number: 7883584
Gerrit-PatchSet: 4
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages