Make crashpad_ios_x64_rel green (by disabling a few tests) [crashpad/crashpad : main]
Justin Cohen (Gerrit)
Justin Cohen added 1 comment![]( "Open in Gerrit")
// TODO(crbug.com/473850381): Fails on intel. Investigate and re-enable.Is this the right bug? I think we need a new bug that shows these failures.
Related details
- Victor Vianna
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Vianna (Gerrit)
Victor Vianna added 1 comment![]( "Open in Gerrit")
// TODO(crbug.com/473850381): Fails on intel. Investigate and re-enable.Is this the right bug? I think we need a new bug that shows these failures.
- Justin Cohen
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Justin Cohen added 2 comments![]( "Open in Gerrit")
What else changed to cause these failures? Is it because we upgraded the intel OS from 13.6.7 to 15.7.3? Did something else change?
Related details
- Victor Vianna
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Justin Cohen added 1 comment![]( "Open in Gerrit")
What else changed to cause these failures? Is it because we upgraded the intel OS from 13.6.7 to 15.7.3? Did something else change?
.
Related details
- Victor Vianna
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Vianna (Gerrit)
Victor Vianna added 2 comments![]( "Open in Gerrit")
Justin CohenWhat else changed to cause these failures? Is it because we upgraded the intel OS from 13.6.7 to 15.7.3? Did something else change?
.
Yep, that was the inital trigger. Note there were a couple of steps though:
1. We upgraded the OS
2. After that, no iOS tests run because the bot can't find the proper simulator runtime
3. We change Xcode version and the target simulator in run_tests.py (crbug.com/473850381#comment5, crbug.com/473850381#comment9, crrev.com/c/7274281)
4. After that, most test suites pass but nothing in ios_crash_xcuitests runs
5. We remove DYLD_INSERT_LIBRARIES (this CL)
6. After that, only 3 remaining tests in ios_crash_xcuitests fail
7. We disable the tests (this CL)
8. The bot is green.
Related details
- Justin Cohen
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Justin Cohen voted and added 1 comment![]( "Open in Gerrit")
Votes added by Justin Cohen
| Code-Review | +1 |
1 comment
LGTM, I'll note the OS change in the bug.
Related details
- Victor Vianna
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Make crashpad_ios_x64_rel green (by disabling a few tests)
Use the same strategy as crrev.com/c/5738253 to get ios_crash_xcuitests
(mostly) passing, i.e. remove DYLD_INSERT_LIBRARIES. There were still
3 failing tests after that, so disable them for now.
- M build/run_tests.py
- M test/ios/crash_type_xctest.mm
Code-Review: +1 by Justin Cohen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |