rate-limit: use token bucket in ShouldRateLimit() [crashpad/crashpad : main]
Jesse McKenna (Gerrit)
Jesse McKenna added 2 comments![]( "Open in Gerrit")
mark@: PTAL - I've updated this based on crrev.com/c/7038272. Any and all feedback is welcome. Thanks!
if (quota_used == -1) {Jesse McKennaThis gets real weird when we make max_quota > 1, like if one of our saved timestamps are in the future, we'll still want it to count, but what report reason should we give for "5 reports have unexpected time, 7 are recent, so we've used 12 quota which is our max".
I don't think this is worth saving, and don't know how to preserve it past 1 max_quota. WDYT?
Extremely belated update for posterity: I changed the logic from "quota used" to "number of attempts in interval" and I'm hoping that way around makes the code a bit less awkward.
P.S. just in case pbos@ sees this, hi!! Hope you and yours are doing well! : )
Related details
- Mark Mentovai
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Mark Mentovai added 1 comment![]( "Open in Gerrit")
Before we get this into Crashpad, can you do a Crashpad roll into Chromium with your earlier change, so we can get that canary-tested in Chrome separately from this?
Crashpad imports into Chromium can be done by running third_party/Crashpad/update.py from a Chromium checkout.
Will review this next week.
Related details
- Jesse McKenna
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jesse McKenna (Gerrit)
Jesse McKenna added 1 comment![]( "Open in Gerrit")
Before we get this into Crashpad, can you do a Crashpad roll into Chromium with your earlier change, so we can get that canary-tested in Chrome separately from this?
Crashpad imports into Chromium can be done by running third_party/Crashpad/update.py from a Chromium checkout.
Will review this next week.
Okay, will do! Thanks for the explanation.
Related details
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |