[util] Use std::atomic in file_io_test [crashpad/crashpad : main]
7 views
Skip to first unread message
Aaron Teo (Gerrit)
8:51 AM (5 hours ago) 8:51 AM
to Mark Mentovai, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Mark Mentovai
Aaron Teo added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
8:56 AM (5 hours ago) 8:56 AM
to Aaron Teo, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Aaron Teo
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Aaron Teo
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aaron Teo (Gerrit)
9:01 AM (5 hours ago) 9:01 AM
to Mark Mentovai, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Aaron Teo voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
crashpad-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
9:01 AM (5 hours ago) 9:01 AM
to Aaron Teo, Mark Mentovai, crashp...@chromium.org
crashpa...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[util] Use std::atomic in file_io_test
Replace base::subtle::Atomic32 and NoBarrier_* calls with
std::atomic<int32_t> using relaxed memory order. Also apply the flock
support config to util_test so the guarded file locking tests are built.
Bug: 40175832
Change-Id: Ie47cb23808b69aa3d8c16141142355877c4bb126
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Aaron Teo <hoch...@chromium.org>
Files:
- M util/BUILD.gn
- M util/file/file_io_test.cc
Change size: S
Delta: 2 files changed, 10 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages