[util] Use std::atomic in file_io_test [crashpad/crashpad : main]

7 views
Skip to first unread message

Aaron Teo (Gerrit)

unread,
8:51 AM (5 hours ago) 8:51 AM
to Mark Mentovai, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Mark Mentovai

Aaron Teo added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ie47cb23808b69aa3d8c16141142355877c4bb126
Gerrit-Change-Number: 7816914
Gerrit-PatchSet: 1
Gerrit-Owner: Aaron Teo <hoch...@chromium.org>
Gerrit-Reviewer: Aaron Teo <hoch...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 05 May 2026 10:11:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
8:56 AM (5 hours ago) 8:56 AM
to Aaron Teo, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org
Attention needed from Aaron Teo

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Teo
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ie47cb23808b69aa3d8c16141142355877c4bb126
Gerrit-Change-Number: 7816914
Gerrit-PatchSet: 1
Gerrit-Owner: Aaron Teo <hoch...@chromium.org>
Gerrit-Reviewer: Aaron Teo <hoch...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Attention: Aaron Teo <hoch...@chromium.org>
Gerrit-Comment-Date: Tue, 05 May 2026 12:56:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Aaron Teo (Gerrit)

unread,
9:01 AM (5 hours ago) 9:01 AM
to Mark Mentovai, crashpa...@luci-project-accounts.iam.gserviceaccount.com, crashp...@chromium.org

Aaron Teo voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ie47cb23808b69aa3d8c16141142355877c4bb126
Gerrit-Change-Number: 7816914
Gerrit-PatchSet: 1
Gerrit-Owner: Aaron Teo <hoch...@chromium.org>
Gerrit-Reviewer: Aaron Teo <hoch...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Tue, 05 May 2026 13:01:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

crashpad-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
9:01 AM (5 hours ago) 9:01 AM
to Aaron Teo, Mark Mentovai, crashp...@chromium.org

crashpa...@luci-project-accounts.iam.gserviceaccount.com submitted the change

Change information

Commit message:
[util] Use std::atomic in file_io_test

Replace base::subtle::Atomic32 and NoBarrier_* calls with
std::atomic<int32_t> using relaxed memory order. Also apply the flock
support config to util_test so the guarded file locking tests are built.
Bug: 40175832
Change-Id: Ie47cb23808b69aa3d8c16141142355877c4bb126
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Commit-Queue: Aaron Teo <hoch...@chromium.org>
Files:
  • M util/BUILD.gn
  • M util/file/file_io_test.cc
Change size: S
Delta: 2 files changed, 10 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: Ie47cb23808b69aa3d8c16141142355877c4bb126
Gerrit-Change-Number: 7816914
Gerrit-PatchSet: 2
Gerrit-Owner: Aaron Teo <hoch...@chromium.org>
Gerrit-Reviewer: Aaron Teo <hoch...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages