[mac] Add memory capture support for crash reports [crashpad/crashpad : main]
12 views
Skip to first unread message
Miles Chen (Gerrit)
Jan 5, 2026, 9:21:43 AMJan 5
to Mark Mentovai, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen, Mark Mentovai and Miles Chen
Miles Chen voted and added 1 comment![]( "Open in Gerrit")
Votes added by Miles Chen
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Miles Chen . resolved
Hi,
This CL adds memory capture support for macOS, similar to the existing
Windows and Linux implementations. It captures memory regions referenced
by CPU register values to improve crash analysis.
Would appreciate your review. Thanks!
Related details
Attention is currently required from:
- Justin Cohen
- Mark Mentovai
- Miles Chen
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Miles Chen (Gerrit)
Jan 5, 2026, 9:21:43 AMJan 5
to Mark Mentovai, Justin Cohen, crashp...@chromium.org
Attention needed from Justin Cohen, Mark Mentovai and Miles Chen
Miles Chen has uploaded the change for review![]( "Open in Gerrit")
Miles Chen would like Mark Mentovai and Justin Cohen to review this change.
Commit message
[mac] Add memory capture support for crash reports
Add the ability to capture indirectly referenced memory for macOS
crash reports, similar to the existing Windows and Linux implementations.
Bug: crashpad:471492281
Change-Id: I5f980b7ea3ae3190b7b259384b74665f585ed97d
Change diff
Change information
Files:
- M AUTHORS
- M snapshot/BUILD.gn
- A snapshot/mac/capture_memory_delegate_mac.cc
- A snapshot/mac/capture_memory_delegate_mac.h
- M snapshot/mac/exception_snapshot_mac.cc
- M snapshot/mac/exception_snapshot_mac.h
- M snapshot/mac/process_reader_mac.cc
- M snapshot/mac/process_reader_mac.h
- M snapshot/mac/process_reader_mac_test.cc
- M snapshot/mac/process_snapshot_mac.cc
- M snapshot/mac/process_snapshot_mac.h
- M snapshot/mac/thread_snapshot_mac.cc
- M snapshot/mac/thread_snapshot_mac.h
Change size: L
Delta: 13 files changed, 397 insertions(+), 12 deletions(-)
Related details
Attention is currently required from:
- Justin Cohen
- Mark Mentovai
- Miles Chen
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Miles Chen (Gerrit)
Jan 15, 2026, 4:24:26 AMJan 15
to Mark Mentovai, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Justin Cohen and Mark Mentovai
Miles Chen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Justin Cohen
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Miles Chen (Gerrit)
Feb 27, 2026, 2:43:37 AM (yesterday) Feb 27
to Will Harris, Joshua Peraza, Mark Mentovai, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Joshua Peraza and Will Harris
Miles Chen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Miles Chen . resolved
Gently pinging. Adding @w...@chromium.org and @jpe...@chromium.org to help move this forward since Mark and Justin may be busy. Thanks for taking a look 😊
Related details
Attention is currently required from:
- Joshua Peraza
- Will Harris
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Will Harris (Gerrit)
Feb 27, 2026, 11:18:12 AM (16 hours ago) Feb 27
to Miles Chen, Will Harris, Joshua Peraza, Mark Mentovai, Justin Cohen, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Joshua Peraza, Mark Mentovai and Miles Chen
Will Harris added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Will Harris . unresolved
this needs a macOS expert to look at it and my expertise is in Windows, so you might have to find someone.
this might also need a security or privacy review if we are expanding the memory being captured, to make sure it's no more than is needed and functionally equivalent to other platforms.
Related details
Attention is currently required from:
- Joshua Peraza
- Mark Mentovai
- Miles Chen
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages