[mac] Add memory capture support for crash reports [crashpad/crashpad : main]

[Miles Chen (Gerrit)]

Attention needed from Justin Cohen, Mark Mentovai and Miles Chen

Miles Chen voted and added 1 comment

Votes added by Miles Chen

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Miles Chen . resolved

Hi,

This CL adds memory capture support for macOS, similar to the existing
Windows and Linux implementations. It captures memory regions referenced
by CPU register values to improve crash analysis.

Would appreciate your review. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Justin Cohen
• Mark Mentovai
• Miles Chen

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: crashpad/crashpad

Gerrit-Branch: main

Gerrit-Change-Id: I5f980b7ea3ae3190b7b259384b74665f585ed97d

Gerrit-Change-Number: 7330347

Gerrit-PatchSet: 1

Gerrit-Owner: Miles Chen <mile...@gmail.com>

Gerrit-Reviewer: Justin Cohen <justi...@chromium.org>

Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>

Gerrit-Reviewer: Miles Chen <mile...@gmail.com>

Gerrit-CC: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Mark Mentovai <ma...@chromium.org>

Gerrit-Attention: Miles Chen <mile...@gmail.com>

Gerrit-Attention: Justin Cohen <justi...@chromium.org>

Gerrit-Comment-Date: Fri, 26 Dec 2025 03:17:36 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Miles Chen (Gerrit)]

Attention needed from Justin Cohen, Mark Mentovai and Miles Chen

Miles Chen has uploaded the change for review

Miles Chen would like Mark Mentovai and Justin Cohen to review this change.

Commit message

[mac] Add memory capture support for crash reports

Add the ability to capture indirectly referenced memory for macOS
crash reports, similar to the existing Windows and Linux implementations.

Bug: crashpad:471492281

Change-Id: I5f980b7ea3ae3190b7b259384b74665f585ed97d

Change diff

Change information

Files:

• M AUTHORS
• M snapshot/BUILD.gn
• A snapshot/mac/capture_memory_delegate_mac.cc
• A snapshot/mac/capture_memory_delegate_mac.h
• M snapshot/mac/exception_snapshot_mac.cc
• M snapshot/mac/exception_snapshot_mac.h
• M snapshot/mac/process_reader_mac.cc
• M snapshot/mac/process_reader_mac.h
• M snapshot/mac/process_reader_mac_test.cc
• M snapshot/mac/process_snapshot_mac.cc
• M snapshot/mac/process_snapshot_mac.h
• M snapshot/mac/thread_snapshot_mac.cc
• M snapshot/mac/thread_snapshot_mac.h

Change size: L

Delta: 13 files changed, 397 insertions(+), 12 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

• Justin Cohen
• Mark Mentovai
• Miles Chen

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange