util: DO an arm64 TODO in MacModelAndBoard [crashpad/crashpad : main]
1 view
Skip to first unread message
Mark Mentovai (Gerrit)
Jul 29, 2025, 11:19:08 AMJul 29
to Justin Cohen, Christine Hollingsworth, crashp...@chromium.org
Attention needed from Justin Cohen
Mark Mentovai voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Mentovai
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Mark Mentovai . resolved
Justin for review. (iOS has a TODO about maybe doing something similar, in util/ios/ios_system_data_collector.mm, but right now the device builds just use `utsname::machine`, which is probably always `"arm64"` and not very interesting.)
Christine for exposure.
Related details
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
Jul 29, 2025, 2:38:43 PMJul 29
to Mark Mentovai, Crashpad LUCI CQ, Christine Hollingsworth, crashp...@chromium.org
Attention needed from Mark Mentovai
Justin Cohen voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Jul 30, 2025, 10:37:55 AMJul 30
to Justin Cohen, Crashpad LUCI CQ, Christine Hollingsworth, crashp...@chromium.org
Mark Mentovai voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
Jul 30, 2025, 10:54:42 AMJul 30
to Justin Cohen, Crashpad LUCI CQ, Christine Hollingsworth, crashp...@chromium.org
Mark Mentovai voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Jul 30, 2025, 10:54:53 AMJul 30
to Mark Mentovai, Justin Cohen, Christine Hollingsworth, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
util: DO an arm64 TODO in MacModelAndBoard
The board_id returned on mac-arm64 was taken from the target-type
property of the IOPlatformExpertDevice obtained through IOKit when this
code was written on a mac-arm64 Developer Transition Kit, with a TODO to
verify with production hardware. Several generations of production
hardware have shown that this is a viable strategy. In fact, a slightly
more detailed ID can be obtained from the target-sub-type property.
mac-x86_64 continues to use the board-id property for this purpose.
Test: crashpad_util_test MacUtil.MacModelAndBoard
Change-Id: I81d5052d1a9cd7a76b6b4593fb4115a251409de7
Commit-Queue: Mark Mentovai <ma...@chromium.org>
Reviewed-by: Justin Cohen <justi...@chromium.org>
Files:
- M util/mac/mac_util.cc
- M util/mac/mac_util.h
Change size: S
Delta: 2 files changed, 17 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Justin Cohen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages