[Fuchsia] remove the use of fuchsia-sdk:build/config/config.gni [chromium/mini_chromium : main]
0 views
Skip to first unread message
Zijie He (Gerrit)
May 30, 2024, 7:29:34 PMMay 30
to Mark Mentovai, Ben Pastene, Justin Cohen, crashp...@chromium.org
Attention needed from Mark Mentovai
Zijie He added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Zijie He . resolved
Hey, Mark, would you please take a look at this change? Thank you.
Related details
Attention is currently required from:
- Mark Mentovai
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
May 31, 2024, 10:21:21 AMMay 31
to Zijie He, Ben Pastene, Justin Cohen, crashp...@chromium.org
Attention needed from Zijie He
Mark Mentovai voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Zijie He
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Mentovai (Gerrit)
May 31, 2024, 10:21:25 AMMay 31
to Zijie He, Ben Pastene, Justin Cohen, crashp...@chromium.org
Mark Mentovai submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Fuchsia] remove the use of fuchsia-sdk:build/config/config.gni
The file has been removed already. The reference is now breaking
crashpad, see https://crrev.com/c/5585353.
```
zij...@zijiehe.c.googlers.com - Thu May 30-15:29:19:~/chromium/chromium/src$ ll third_party/fuchsia-sdk/sdk/build/
total 16
drwxr-x--- 2 zijiehe primarygroup 4096 May 28 13:27 ./
drwxr-x--- 18 zijiehe primarygroup 4096 May 28 13:27 ../
-rw-r----- 1 zijiehe primarygroup 193 May 28 13:27 component.gni
-rw-r----- 1 zijiehe primarygroup 191 May 28 13:27 package.gni
```
Bug: fuchsia:42085580, fuchsia:327691011
Change-Id: I26cf3e35e67e4ed478091781aa62e0298347ba76
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
- M build/sysroot.gni
Change size: XS
Delta: 1 file changed, 0 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mark Mentovai
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages