Fix C++23 build errors in crashpad [crashpad/crashpad : main]
1 view
Skip to first unread message
Victor Vianna (Gerrit)
Dec 17, 2025, 5:36:56 PM (2 days ago) Dec 17
to Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Joshua Peraza
Victor Vianna added 2 comments![]( "Open in Gerrit")
File util/linux/socket_test.cc
File-level comment, Patchset 1 (Latest):
Victor Vianna . resolved
```
../../util/linux/socket_test.cc:129:51: error: variable 'c' is uninitialized when passed as a const pointer argument here [-Werror,-Wuninitialized-const-pointer]
129 | HANDLE_EINTR(send(send_fds[index].get(), &c, sizeof(c), MSG_NOSIGNAL)),
```
File util/linux/thread_info.cc
File-level comment, Patchset 1 (Latest):
Victor Vianna . resolved
```
../../util/linux/thread_info.cc:22:10: error: first argument in call to 'memset' is a pointer to non-trivially copyable type 'crashpad::ThreadContext' [-Werror,-Wnontrivial-memcall]
22 | memset(this, 0, sizeof(*this));
| ^
../../util/linux/thread_info.cc:22:10: note: explicitly cast the pointer to silence this warning
22 | memset(this, 0, sizeof(*this));
| ^
| (void*)
../../util/linux/thread_info.cc:28:10: error: first argument in call to 'memset' is a pointer to non-trivially copyable type 'crashpad::FloatContext' [-Werror,-Wnontrivial-memcall]
28 | memset(this, 0, sizeof(*this));
| ^
../../util/linux/thread_info.cc:28:10: note: explicitly cast the pointer to silence this warning
28 | memset(this, 0, sizeof(*this));
| ^
| (void*)
```
Related details
Attention is currently required from:
- Joshua Peraza
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joshua Peraza (Gerrit)
Dec 17, 2025, 5:39:13 PM (2 days ago) Dec 17
to Victor Vianna, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Victor Vianna
Joshua Peraza voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Victor Vianna
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Victor Vianna (Gerrit)
Dec 17, 2025, 5:54:33 PM (2 days ago) Dec 17
to Joshua Peraza, Crashpad LUCI CQ, crashp...@chromium.org
Victor Vianna voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Crashpad LUCI CQ (Gerrit)
Dec 17, 2025, 5:54:40 PM (2 days ago) Dec 17
to Victor Vianna, Joshua Peraza, crashp...@chromium.org
Crashpad LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix C++23 build errors in crashpad
Bug: 388070065
Change-Id: Iaa150463bcae34db0f3ea022cd25df3035112704
Reviewed-by: Joshua Peraza <jpe...@chromium.org>
Commit-Queue: Victor Vianna <victor...@google.com>
Files:
- M util/linux/socket_test.cc
- M util/linux/thread_info.cc
Change size: XS
Delta: 2 files changed, 3 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joshua Peraza
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages