Roll crashpad/third_party/mini_chromium/mini_chromium/ a6607b1fd..5856e1ea6 (2 commits) [crashpad/crashpad : main]

2 views
Skip to first unread message

Peter Boström (Gerrit)

unread,
May 16, 2024, 3:12:24 PMMay 16
to Mark Mentovai, crashp...@chromium.org
Attention needed from Mark Mentovai

Peter Boström voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mark Mentovai
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I6d1385739042fa5b826bfa91c50b914eebaaf8fd
Gerrit-Change-Number: 5544927
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Boström <pb...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Peter Boström <pb...@chromium.org>
Gerrit-Attention: Mark Mentovai <ma...@chromium.org>
Gerrit-Comment-Date: Thu, 16 May 2024 19:12:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
open
diffy

Mark Mentovai (Gerrit)

unread,
May 16, 2024, 3:13:20 PMMay 16
to Peter Boström, Crashpad LUCI CQ, crashp...@chromium.org
Attention needed from Peter Boström

Mark Mentovai voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Peter Boström
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I6d1385739042fa5b826bfa91c50b914eebaaf8fd
Gerrit-Change-Number: 5544927
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Boström <pb...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Peter Boström <pb...@chromium.org>
Gerrit-Attention: Peter Boström <pb...@chromium.org>
Gerrit-Comment-Date: Thu, 16 May 2024 19:13:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Peter Boström (Gerrit)

unread,
May 16, 2024, 3:13:48 PMMay 16
to Mark Mentovai, Crashpad LUCI CQ, crashp...@chromium.org

Peter Boström voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I6d1385739042fa5b826bfa91c50b914eebaaf8fd
Gerrit-Change-Number: 5544927
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Boström <pb...@chromium.org>
Gerrit-Reviewer: Mark Mentovai <ma...@chromium.org>
Gerrit-Reviewer: Peter Boström <pb...@chromium.org>
Gerrit-Comment-Date: Thu, 16 May 2024 19:13:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Crashpad LUCI CQ (Gerrit)

unread,
May 16, 2024, 8:10:07 PMMay 16
to Peter Boström, Mark Mentovai, crashp...@chromium.org

Crashpad LUCI CQ submitted the change

Change information

Commit message:
Roll crashpad/third_party/mini_chromium/mini_chromium/ a6607b1fd..5856e1ea6 (2 commits)

https://chromium.googlesource.com/chromium/mini_chromium/+log/a6607b1fd76b..5856e1ea610f

$ git log a6607b1fd..5856e1ea6 --date=short --no-merges --format='%ad %ae %s'
2024-05-16 pbos Add NOTREACHED_IN_MIGRATION()
2024-05-11 pwjworks Remove workaround for missing std::atomic_thread_fence

Created with:
roll-dep crashpad/third_party/mini_chromium/mini_chromium
Bug: chromium:40580068
Change-Id: I6d1385739042fa5b826bfa91c50b914eebaaf8fd
Commit-Queue: Peter Boström <pb...@chromium.org>
Reviewed-by: Mark Mentovai <ma...@chromium.org>
Files:
  • M DEPS
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mark Mentovai
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crashpad/crashpad
Gerrit-Branch: main
Gerrit-Change-Id: I6d1385739042fa5b826bfa91c50b914eebaaf8fd
Gerrit-Change-Number: 5544927
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Boström <pb...@chromium.org>
Gerrit-Reviewer: Crashpad LUCI CQ <crashpa...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages