Is this check needed?

[Matthew Spelman]

https://source.chromium.org/chromium/chromium/src/+/main:third_party/crashpad/crashpad/client/crashpad_client_linux.cc;l=451;drc=ca6066aa89b3a11f92f5587c83b43a22da8c6d6b;bpv=1;bpt=1

DCHECK(!asynchronous_start);

This prevents true from being passed as the value for the asynchronous_start parameter on Linux, but from what I can see, this parameter isn't used on Linux anyway, so it shouldn't matter what the value is. The documentation says that "This option is only used on Windows", so I'd expect the handling of this value to be the same as the "restartable" parameter, which is simply ignored (which is also consistent with its documentation).

[Joshua Peraza]

Nothing bad will happen if you remove it. It is only to bring attention to it's not being supported in case it was mistakenly set.

--
You received this message because you are subscribed to the Google Groups "Crashpad-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to crashpad-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/crashpad-dev/4d0e2c2a-5680-4dee-8995-cc7c38698626n%40chromium.org.

[Matthew Spelman]

Thanks for clarifying!