Revert "Roll Fuchsia SDK from 11.20230202.3.1 to 11.20230204.1.1" [chromium/src : main]

0 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
Feb 5, 2023, 7:16:26 PM2/5/23
to cr-fu...@chromium.org, chrome-fuch...@grotations.appspotmail.com, Daniel Cheng, Rubber Stamper, Chromium LUCI CQ, chromium-autoroll

Daniel Cheng has uploaded this change for review.

View Change

Revert "Roll Fuchsia SDK from 11.20230202.3.1 to 11.20230204.1.1"

This reverts commit b05681c32ae99cad13d00f44cc7dcb42afec0f39.

Reason for revert: Chrome tree is closed due to build failures, e.g.
https://cr-buildbucket.appspot.com/build/8790094375859630209

Original change's description:
> Roll Fuchsia SDK from 11.20230202.3.1 to 11.20230204.1.1
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
> Please CC chrome-fuch...@grotations.appspotmail.com,cr-fu...@chromium.org on the revert to ensure that a human
> is aware of the problem.
>
> To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
>
> Tbr: chrome-fuch...@grotations.appspotmail.com
> Disable-Retries: true
> Change-Id: Icbe1baebcfd83433bf4a728d0453f8748f7b6d05
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4222811
> Bot-Commit: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1101347}

Change-Id: I625f574ca774a0085122b490a18d2913b3e6e222
---
M DEPS
1 file changed, 40 insertions(+), 1 deletion(-)

diff --git a/DEPS b/DEPS
index bf80c11..7998fa7 100644
--- a/DEPS
+++ b/DEPS
@@ -326,7 +326,7 @@
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling Fuchsia sdk
# and whatever else without interference from each other.
- 'fuchsia_version': 'version:11.20230204.1.1',
+ 'fuchsia_version': 'version:11.20230202.3.1',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling google-toolbox-for-mac
# and whatever else without interference from each other.

To view, visit change 4223156. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I625f574ca774a0085122b490a18d2913b3e6e222
Gerrit-Change-Number: 4223156
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
Gerrit-MessageType: newchange

Daniel Cheng (Gerrit)

unread,
Feb 5, 2023, 7:16:29 PM2/5/23
to Daniel Cheng, cr-fu...@chromium.org, chrome-fuch...@grotations.appspotmail.com, Rubber Stamper, Chromium LUCI CQ, chromium-autoroll, luci-bi...@appspot.gserviceaccount.com

Patch set 1:Auto-Submit +1Owners-Override +1Commit-Queue +1

View Change

    To view, visit change 4223156. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I625f574ca774a0085122b490a18d2913b3e6e222
    Gerrit-Change-Number: 4223156
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
    Gerrit-Comment-Date: Mon, 06 Feb 2023 00:16:20 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Daniel Cheng (Gerrit)

    unread,
    Feb 5, 2023, 7:16:42 PM2/5/23
    to Daniel Cheng, cr-fu...@chromium.org, chrome-fuch...@grotations.appspotmail.com, Rubber Stamper, Chromium LUCI CQ, chromium-autoroll, luci-bi...@appspot.gserviceaccount.com

    Patch set 1:Commit-Queue +2

    View Change

      To view, visit change 4223156. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I625f574ca774a0085122b490a18d2913b3e6e222
      Gerrit-Change-Number: 4223156
      Gerrit-PatchSet: 1
      Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
      Gerrit-Reviewer: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
      Gerrit-Comment-Date: Mon, 06 Feb 2023 00:16:29 +0000

      Lingqi Chi (Gerrit)

      unread,
      Feb 5, 2023, 8:01:11 PM2/5/23
      to Daniel Cheng, cr-fu...@chromium.org, chrome-fuch...@grotations.appspotmail.com

      Lingqi Chi uploaded patch set #2 to the change originally created by Daniel Cheng.

      View Change

      The following approvals got outdated and were removed: Bot-Commit+1 by Rubber Stamper

      The change is no longer submittable: Code-Review is unsatisfied now.

      Revert "Roll Fuchsia SDK from 11.20230202.3.1 to 11.20230204.1.1"

      This reverts commit b05681c32ae99cad13d00f44cc7dcb42afec0f39.

      Reason for revert: Chrome tree is closed due to build failures, e.g.
      https://cr-buildbucket.appspot.com/build/8790094375859630209

      Original change's description:
      > Roll Fuchsia SDK from 11.20230202.3.1 to 11.20230204.1.1
      >
      > If this roll has caused a breakage, revert this CL and stop the roller
      > using the controls here:
      > https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
      > Please CC chrome-fuch...@grotations.appspotmail.com,cr-fu...@chromium.org on the revert to ensure that a human
      > is aware of the problem.
      >
      > To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
      >
      > To report a problem with the AutoRoller itself, please file a bug:
      > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      >
      > Documentation for the AutoRoller is here:
      > https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
      >
      > Tbr: chrome-fuch...@grotations.appspotmail.com
      > Disable-Retries: true
      > Change-Id: Icbe1baebcfd83433bf4a728d0453f8748f7b6d05
      > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4222811
      > Bot-Commit: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
      > Commit-Queue: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
      > Cr-Commit-Position: refs/heads/main@{#1101347}

      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true

      Change-Id: I625f574ca774a0085122b490a18d2913b3e6e222
      ---
      M DEPS
      1 file changed, 43 insertions(+), 1 deletion(-)

      To view, visit change 4223156. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I625f574ca774a0085122b490a18d2913b3e6e222
      Gerrit-Change-Number: 4223156
      Gerrit-PatchSet: 2
      Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
      Gerrit-Reviewer: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
      Gerrit-CC: Lingqi Chi <lin...@chromium.org>
      Gerrit-MessageType: newpatchset

      Lingqi Chi (Gerrit)

      unread,
      Feb 5, 2023, 8:01:30 PM2/5/23
      to Daniel Cheng, cr-fu...@chromium.org, chrome-fuch...@grotations.appspotmail.com, Rubber Stamper, Chromium LUCI CQ, chromium-autoroll, luci-bi...@appspot.gserviceaccount.com

      Attention is currently required from: Daniel Cheng.

      Patch set 2:Commit-Queue +2

      View Change

        To view, visit change 4223156. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I625f574ca774a0085122b490a18d2913b3e6e222
        Gerrit-Change-Number: 4223156
        Gerrit-PatchSet: 2
        Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Lingqi Chi <lin...@chromium.org>
        Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
        Gerrit-Reviewer: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
        Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
        Gerrit-Comment-Date: Mon, 06 Feb 2023 01:01:15 +0000

        Lingqi Chi (Gerrit)

        unread,
        Feb 5, 2023, 8:01:49 PM2/5/23
        to Daniel Cheng, cr-fu...@chromium.org, chrome-fuch...@grotations.appspotmail.com, Rubber Stamper, Chromium LUCI CQ, chromium-autoroll, luci-bi...@appspot.gserviceaccount.com

        Attention is currently required from: Daniel Cheng.

        Patch set 2:Code-Review +1Commit-Queue +2

        View Change

          To view, visit change 4223156. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I625f574ca774a0085122b490a18d2913b3e6e222
          Gerrit-Change-Number: 4223156
          Gerrit-PatchSet: 2
          Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
          Gerrit-Reviewer: Lingqi Chi <lin...@chromium.org>
          Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
          Gerrit-Reviewer: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
          Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
          Gerrit-Comment-Date: Mon, 06 Feb 2023 01:01:42 +0000

          Rubber Stamper (Gerrit)

          unread,
          Feb 5, 2023, 8:02:10 PM2/5/23
          to Daniel Cheng, Lingqi Chi, cr-fu...@chromium.org, chrome-fuch...@grotations.appspotmail.com, Chromium LUCI CQ, chromium-autoroll, luci-bi...@appspot.gserviceaccount.com

          Attention is currently required from: Daniel Cheng, Lingqi Chi.

          Patch set 2:Bot-Commit +1Commit-Queue +2

          View Change

            To view, visit change 4223156. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I625f574ca774a0085122b490a18d2913b3e6e222
            Gerrit-Change-Number: 4223156
            Gerrit-PatchSet: 2
            Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
            Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
            Gerrit-Reviewer: Lingqi Chi <lin...@chromium.org>
            Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
            Gerrit-Reviewer: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
            Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
            Gerrit-Attention: Lingqi Chi <lin...@chromium.org>
            Gerrit-Comment-Date: Mon, 06 Feb 2023 01:02:03 +0000

            Lingqi Chi (Gerrit)

            unread,
            Feb 5, 2023, 8:02:32 PM2/5/23
            to Daniel Cheng, cr-fu...@chromium.org, chrome-fuch...@grotations.appspotmail.com, Rubber Stamper, Chromium LUCI CQ, chromium-autoroll, luci-bi...@appspot.gserviceaccount.com

            Attention is currently required from: Daniel Cheng.

            Patch set 2:Owners-Override +1Commit-Queue +2

            View Change

              To view, visit change 4223156. To unsubscribe, or for help writing mail filters, visit settings.

              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I625f574ca774a0085122b490a18d2913b3e6e222
              Gerrit-Change-Number: 4223156
              Gerrit-PatchSet: 2
              Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
              Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
              Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
              Gerrit-Reviewer: Lingqi Chi <lin...@chromium.org>
              Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
              Gerrit-Reviewer: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
              Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
              Gerrit-Comment-Date: Mon, 06 Feb 2023 01:02:22 +0000

              Chromium LUCI CQ (Gerrit)

              unread,
              Feb 5, 2023, 8:03:13 PM2/5/23
              to Daniel Cheng, cr-fu...@chromium.org, chrome-fuch...@grotations.appspotmail.com, Lingqi Chi, Rubber Stamper, chromium-autoroll, luci-bi...@appspot.gserviceaccount.com

              Chromium LUCI CQ submitted this change.

              View Change

              Approvals: Rubber Stamper: Commit; Looks good to me Daniel Cheng: Send CL to CQ automatically after approval; Looks good to me Lingqi Chi: Looks good to me; Commit; Looks good to me
              Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4223156
              Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
              Reviewed-by: Lingqi Chi <lin...@chromium.org>
              Owners-Override: Daniel Cheng <dch...@chromium.org>
              Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
              Owners-Override: Lingqi Chi <lin...@chromium.org>
              Auto-Submit: Daniel Cheng <dch...@chromium.org>
              Commit-Queue: Lingqi Chi <lin...@chromium.org>
              Cr-Commit-Position: refs/heads/main@{#1101352}
              ---
              M DEPS
              1 file changed, 52 insertions(+), 1 deletion(-)

              diff --git a/DEPS b/DEPS
              index 5337360..a4ff6e3 100644

              --- a/DEPS
              +++ b/DEPS
              @@ -326,7 +326,7 @@
              # Three lines of non-changing comments so that
              # the commit queue can handle CLs rolling Fuchsia sdk
              # and whatever else without interference from each other.
              - 'fuchsia_version': 'version:11.20230204.1.1',
              + 'fuchsia_version': 'version:11.20230202.3.1',
              # Three lines of non-changing comments so that
              # the commit queue can handle CLs rolling google-toolbox-for-mac
              # and whatever else without interference from each other.

              To view, visit change 4223156. To unsubscribe, or for help writing mail filters, visit settings.

              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I625f574ca774a0085122b490a18d2913b3e6e222
              Gerrit-Change-Number: 4223156
              Gerrit-PatchSet: 3
              Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
              Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
              Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
              Gerrit-Reviewer: Lingqi Chi <lin...@chromium.org>
              Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
              Gerrit-Reviewer: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
              Gerrit-MessageType: merged

              Wez (Gerrit)

              unread,
              Feb 6, 2023, 9:41:02 AM2/6/23
              to Daniel Cheng, Chromium LUCI CQ, cr-fu...@chromium.org, chrome-fuch...@grotations.appspotmail.com, Lingqi Chi, Rubber Stamper, chromium-autoroll, luci-bi...@appspot.gserviceaccount.com

              Attention is currently required from: Daniel Cheng.

              View Change

              1 comment:

                • Thanks for taking care of this, but in future please file a bug when reverting a DEPS roll in this way, so that there's something the fact that investigation is required!

              To view, visit change 4223156. To unsubscribe, or for help writing mail filters, visit settings.

              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I625f574ca774a0085122b490a18d2913b3e6e222
              Gerrit-Change-Number: 4223156
              Gerrit-PatchSet: 3
              Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
              Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
              Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
              Gerrit-Reviewer: Lingqi Chi <lin...@chromium.org>
              Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
              Gerrit-Reviewer: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
              Gerrit-CC: Wez <w...@chromium.org>
              Gerrit-Comment-Date: Mon, 06 Feb 2023 14:40:54 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: No
              Gerrit-MessageType: comment

              Daniel Cheng (Gerrit)

              unread,
              Feb 9, 2023, 12:06:08 AM2/9/23
              to Daniel Cheng, Chromium LUCI CQ, cr-fu...@chromium.org, chrome-fuch...@grotations.appspotmail.com, Lingqi Chi, Rubber Stamper, chromium-autoroll, luci-bi...@appspot.gserviceaccount.com

              View Change

              1 comment:

              • Commit Message:

                • Thanks for taking care of this, but in future please file a bug when reverting a DEPS roll in this w […]

                  I followed the procedure mentioned in the CL description that autoroller populates. Perhaps that should be updated 😊

                  (I CCed the requested lists on the revert)

              To view, visit change 4223156. To unsubscribe, or for help writing mail filters, visit settings.

              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I625f574ca774a0085122b490a18d2913b3e6e222
              Gerrit-Change-Number: 4223156
              Gerrit-PatchSet: 3
              Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
              Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
              Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
              Gerrit-Reviewer: Lingqi Chi <lin...@chromium.org>
              Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
              Gerrit-Reviewer: chromium-autoroll <chromium...@skia-public.iam.gserviceaccount.com>
              Gerrit-CC: Wez <w...@chromium.org>
              Gerrit-Comment-Date: Thu, 09 Feb 2023 05:05:57 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: No
              Comment-In-Reply-To: Wez <w...@chromium.org>
              Gerrit-MessageType: comment
              Reply all
              Reply to author
              Forward
              0 new messages