LoadURLParams vs OpenURLParams

[Jonathan Dixon]

We seem to have two very similar classes for describing the parameters to a navigations

LoadURLParams

http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/navigation_controller.h?revision=213324

OpenURLParams

http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/page_navigator.h?revision=212986

Is it intentional that both exist, or should they ultimately be combined?

(Came up as a side question in reviewing https://codereview.chromium.org/21378002/)

Thanks!

[Jochen Eisinger]

IIRC OpenURLParams was introduced because the parameter list of OpenURL became unwieldy. Assuming there is enough overlap, I'd say way can join the two.

Technically, OpenURLParams is used to communicate from content to the embedder, and LoadURLParams is used the other way round (and inside content). However, the embedder ends up converting the OpenURLParams to LoadURLParams anyway when calling back to content to make the navigation.

best

-jochen