Re: [chromium-dev] What may cause Content Shell to crash on posting to a page?

[Avi Drissman]

Pre-rendering? I thought that something like pre-rendering would live in chrome/, not content/. Why is it on this side of the divide?

Avi

On Sat, Aug 25, 2012 at 11:28 AM, Gavin Peters (蓋文彼德斯) <gav...@google.com> wrote:

as a work around until I upload this patch, chrome should work.

- Gavin

Sent from my phone by my fat thumb.  Please excuse my tpyos and brevity.

On Aug 25, 2012 11:27 AM, "Gavin Peters (蓋文彼德斯)" <gav...@google.com> wrote:

This is a bug I need to fix. I'll upload a patch by Monday.

Content shell needs a stub prerendering implementation.

- Gavin

Sent from my phone by my fat thumb.  Please excuse my tpyos and brevity.

On Aug 25, 2012 4:20 AM, "Zhao Cheng" <zcb...@gmail.com> wrote:

Hi, chromium-dev,

Here is a bug I filed previously:
http://code.google.com/p/chromium/issues/detail?can=2&start=0&num=100&q=&colspec=ID%20Pri%20Mstone%20ReleaseBlock%20OS%20Area%20Feature%20Status%20Owner%20Summary&groupby=&sort=&id=144556
, I know I should wait until someone look into that bug, but it's a
bit urgency to me so I decide to fix it myself.

The renderer process stops at
"WebCore::PrerendererClient::from(WebCore::Page*)" with a "ASSERTION
FAILED: supplement" after I submit the login form, but this bug only
appears in Content Shell, so I thought Content Shell must have forgot
to override some important virtual functions, I've looked into the
source for some days but still got no idea how to fix it, could
someone familiar with this give some some hint on where maybe wrong?

Thanks.

--
Cheng
Intel Open Source Technology Center

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
    http://groups.google.com/a/chromium.org/group/chromium-dev

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

[John Abd-El-Malek]

Prerendering is a chrome feature (whether it should move to content or not is an orthogonal discussion).

Code in WebKit shouldn't crash if a prerendering client isn't set. i.e. it handles null autofill/spellcheck clients which are implemented in chrome but not content. Why can't it handle a null client?

[Avi Drissman]

On Sat, Aug 25, 2012 at 2:28 PM, John Abd-El-Malek <j...@chromium.org> wrote:

Why can't it handle a null [prerendering] client?

Indeed. This bug should be fixed by making WebKit ok with not having a prerendering client, not by providing content shell with a stub prerendering implementation.

Avi

[Gavin Peters (蓋文彼德斯)]

Thanks Avi & John, that's how I'll do it.

- Gavin

Sent from my phone by my fat thumb.  Please excuse my tpyos and brevity.

[Gavin Peters (蓋文彼德斯)]

See https://bugs.webkit.org/show_bug.cgi?id=95036 for the fix, and http://codereview.chromium.org/10869068/ for the test on the content side (this couldn't be tested with a layout test, since DumpRenderTree provides a PrerendererClient).

[Zhao Cheng]

Great, thanks for your work.