Adding components/embedder_support headers to content/browser/DEPS

5 views
Skip to first unread message

Raphael Kubo da Costa

unread,
Feb 25, 2025, 5:36:54 PMFeb 25
to content...@chromium.org
Hi content owners,

I'd like to add two //components/entries to content/browser/DEPS:

1. components/embedder_support/switches.h in
https://chromium-review.googlesource.com/c/chromium/src/+/6242721

2. components/embedder_support/user_agent_utils.h in
https://chromium-review.googlesource.com/c/chromium/src/+/6244461

Dependency 1 is part of a target that does not depend on anything (not
even base). Dependency 2 depends on a few more targets (see the CL
above), the idea being that we'll merge content/common/user_agent.h into
it to reduce confusion and consolidate all UA-related code in one place.

Could you let me know what kind of approval is necessary in this case?

Dave Tapuska

unread,
Feb 25, 2025, 6:17:28 PMFeb 25
to Raphael Kubo da Costa, content-owners
I already lgtmd the first patch. Content is allowed to depend on //components. I think the second CL is fine as well, although I'm not certain how the embedder_support targets are setup. I don't think you'd need an explicit sub component if you already are depending main component already. Just add me on the review when it's ready. 

Dave


--
You received this message because you are subscribed to the Google Groups "content-owners" group.
To unsubscribe from this group and stop receiving emails from it, send an email to content-owner...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/content-owners/e4dbd2ef-b4c8-4ac1-a6e0-e1fdacab0789%40igalia.com.
Reply all
Reply to author
Forward
0 new messages